Browse Source

src: force line buffering for stderr

SmartOS does not line buffer stderr by default, or at least that is the
behavior on the Node project Jenkins server. Force line buffering. This
resolves the flakiness observed on SmartOS for
test-debug-signal-cluster.

PR-URL: https://github.com/nodejs/node/pull/3701
Fixes: https://github.com/nodejs/node/issues/2476
Refs: https://github.com/nodejs/node/pull/3615
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
process-exit-stdio-flushing
Rich Trott 9 years ago
parent
commit
0966ab9996
  1. 1
      src/node_main.cc
  2. 1
      test/parallel/parallel.status

1
src/node_main.cc

@ -41,6 +41,7 @@ int wmain(int argc, wchar_t *wargv[]) {
#else
// UNIX
int main(int argc, char *argv[]) {
setvbuf(stderr, NULL, _IOLBF, 1024);
return node::Start(argc, argv);
}
#endif

1
test/parallel/parallel.status

@ -18,7 +18,6 @@ test-child-process-exit-code : PASS,FLAKY
[$system==macos]
[$system==solaris] # Also applies to SmartOS
test-debug-signal-cluster : PASS,FLAKY
[$system==freebsd]
test-net-socket-local-address : PASS,FLAKY

Loading…
Cancel
Save