Browse Source

test: improve test coverage for n-api

Add basic tests for handle scopes as code coverage
reports that we are not covering these with the existing
tests.

PR-URL: https://github.com/nodejs/node/pull/12327
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
v6
Michael Dawson 8 years ago
parent
commit
0ec0272e10
  1. 8
      test/addons-napi/test_handle_scope/binding.gyp
  2. 10
      test/addons-napi/test_handle_scope/test.js
  3. 42
      test/addons-napi/test_handle_scope/test_handle_scope.c

8
test/addons-napi/test_handle_scope/binding.gyp

@ -0,0 +1,8 @@
{
"targets": [
{
"target_name": "test_handle_scope",
"sources": [ "test_handle_scope.c" ]
}
]
}

10
test/addons-napi/test_handle_scope/test.js

@ -0,0 +1,10 @@
'use strict';
const common = require('../../common');
const assert = require('assert');
// testing handle scope api calls
const testHandleScope =
require(`./build/${common.buildType}/test_handle_scope`);
testHandleScope.NewScope();
assert.ok(testHandleScope.NewScopeEscape() instanceof Object);

42
test/addons-napi/test_handle_scope/test_handle_scope.c

@ -0,0 +1,42 @@
#include <node_api.h>
#include "../common.h"
#include <string.h>
// these tests validate the handle scope functions in the normal
// flow. Forcing gc behaviour to fully validate they are doing
// the right right thing would be quite hard so we keep it
// simple for now.
napi_value NewScope(napi_env env, napi_callback_info info) {
napi_handle_scope scope;
napi_value output = NULL;
NAPI_CALL(env, napi_open_handle_scope(env, &scope));
NAPI_CALL(env, napi_create_object(env, &output));
NAPI_CALL(env, napi_close_handle_scope(env, scope));
return NULL;
}
napi_value NewScopeEscape(napi_env env, napi_callback_info info) {
napi_escapable_handle_scope scope;
napi_value output = NULL;
napi_value escapee = NULL;
NAPI_CALL(env, napi_open_escapable_handle_scope(env, &scope));
NAPI_CALL(env, napi_create_object(env, &output));
NAPI_CALL(env, napi_escape_handle(env, scope, output, &escapee));
NAPI_CALL(env, napi_close_escapable_handle_scope(env, scope));
return escapee;
}
void Init(napi_env env, napi_value exports, napi_value module, void* priv) {
napi_property_descriptor properties[] = {
DECLARE_NAPI_PROPERTY("NewScope", NewScope),
DECLARE_NAPI_PROPERTY("NewScopeEscape", NewScopeEscape),
};
NAPI_CALL_RETURN_VOID(env, napi_define_properties(
env, exports, sizeof(properties) / sizeof(*properties), properties));
}
NAPI_MODULE(addon, Init)
Loading…
Cancel
Save