From 108c1fbbe20a8fb87949ed7505784ff4321658be Mon Sep 17 00:00:00 2001 From: "Kyle E. Mitchell" Date: Wed, 19 Oct 2016 13:42:34 -0700 Subject: [PATCH] fs: clarify fs.link and fs.linkSync arguments Updates the argument names `srcpath` and `dstpath` to match the more descriptive `existingPath` and `newPath` in the documentation. PR-URL: https://github.com/nodejs/node/pull/9145 Reviewed-By: Sakthipriyan Vairamani Reviewed-By: James M Snell Reviewed-By: Luigi Pinca Reviewed-By: Gibson Fahnestock --- lib/fs.js | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/lib/fs.js b/lib/fs.js index 49615f941c..b8524c5884 100644 --- a/lib/fs.js +++ b/lib/fs.js @@ -955,24 +955,24 @@ fs.symlinkSync = function(target, path, type) { type); }; -fs.link = function(srcpath, dstpath, callback) { +fs.link = function(existingPath, newPath, callback) { callback = makeCallback(callback); - if (!nullCheck(srcpath, callback)) return; - if (!nullCheck(dstpath, callback)) return; + if (!nullCheck(existingPath, callback)) return; + if (!nullCheck(newPath, callback)) return; var req = new FSReqWrap(); req.oncomplete = callback; - binding.link(pathModule._makeLong(srcpath), - pathModule._makeLong(dstpath), + binding.link(pathModule._makeLong(existingPath), + pathModule._makeLong(newPath), req); }; -fs.linkSync = function(srcpath, dstpath) { - nullCheck(srcpath); - nullCheck(dstpath); - return binding.link(pathModule._makeLong(srcpath), - pathModule._makeLong(dstpath)); +fs.linkSync = function(existingPath, newPath) { + nullCheck(existingPath); + nullCheck(newPath); + return binding.link(pathModule._makeLong(existingPath), + pathModule._makeLong(newPath)); }; fs.unlink = function(path, callback) {