Browse Source

src: remove outdated todo from node_crypto.cc

TODO comment from node_crypto is no longer relevant. Unification of
commented code and string_bytes code would bloat the latter. Methods
for hex encoding produce different output in both files (crypto adds
colon and uses uppercase letters.) Common path between those two is
very limited now.

PR-URL: https://github.com/nodejs/node/pull/15104
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
v6.x-staging
Bartek Szczepański 7 years ago
committed by Myles Borins
parent
commit
13b223123c
No known key found for this signature in database GPG Key ID: 933B01F40B5CA946
  1. 1
      src/node_crypto.cc

1
src/node_crypto.cc

@ -1607,7 +1607,6 @@ static Local<Object> X509ToObject(Environment* env, X509* cert) {
const char hex[] = "0123456789ABCDEF";
char fingerprint[EVP_MAX_MD_SIZE * 3];
// TODO(indutny): Unify it with buffer's code
for (i = 0; i < md_size; i++) {
fingerprint[3*i] = hex[(md[i] & 0xf0) >> 4];
fingerprint[(3*i)+1] = hex[(md[i] & 0x0f)];

Loading…
Cancel
Save