Browse Source

test: update test-domain-uncaught-exception.js

file: test/parallel/test-domain-uncaught-exception.js

1. There are three setTimeout() in the file and they do not specify a
duration (the second argument), so I change them to setImmediate()
instead.

2. There are four callbacks that take an argument called `err` but that
argument is never used, so I removed them.

PR-URL: https://github.com/nodejs/node/pull/10193
Reviewed-By: Sam Roberts <sam@strongloop.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
v4.x
Andy Chen 8 years ago
committed by Myles Borins
parent
commit
14c28ebcf1
No known key found for this signature in database GPG Key ID: 933B01F40B5CA946
  1. 14
      test/parallel/test-domain-uncaught-exception.js

14
test/parallel/test-domain-uncaught-exception.js

@ -25,7 +25,7 @@ function test1() {
d.run(function() { d.run(function() {
setTimeout(function onTimeout() { setTimeout(function onTimeout() {
throw new Error('boom!'); throw new Error('boom!');
}); }, 1);
}); });
} }
@ -59,7 +59,7 @@ function test3() {
const d3 = domain.create(); const d3 = domain.create();
const d4 = domain.create(); const d4 = domain.create();
d3.on('error', function onErrorInD3Domain(err) { d3.on('error', function onErrorInD3Domain() {
process.send('errorHandledByDomain'); process.send('errorHandledByDomain');
}); });
@ -88,7 +88,7 @@ function test4() {
const d5 = domain.create(); const d5 = domain.create();
const d6 = domain.create(); const d6 = domain.create();
d5.on('error', function onErrorInD2Domain(err) { d5.on('error', function onErrorInD2Domain() {
process.send('errorHandledByDomain'); process.send('errorHandledByDomain');
}); });
@ -96,7 +96,7 @@ function test4() {
d6.run(function() { d6.run(function() {
setTimeout(function onTimeout() { setTimeout(function onTimeout() {
throw new Error('boom!'); throw new Error('boom!');
}); }, 1);
}); });
}); });
} }
@ -115,7 +115,7 @@ function test5() {
const d7 = domain.create(); const d7 = domain.create();
const d8 = domain.create(); const d8 = domain.create();
d8.on('error', function onErrorInD3Domain(err) { d8.on('error', function onErrorInD3Domain() {
process.send('errorHandledByDomain'); process.send('errorHandledByDomain');
}); });
@ -139,7 +139,7 @@ function test6() {
const d9 = domain.create(); const d9 = domain.create();
const d10 = domain.create(); const d10 = domain.create();
d10.on('error', function onErrorInD2Domain(err) { d10.on('error', function onErrorInD2Domain() {
process.send('errorHandledByDomain'); process.send('errorHandledByDomain');
}); });
@ -147,7 +147,7 @@ function test6() {
d10.run(function() { d10.run(function() {
setTimeout(function onTimeout() { setTimeout(function onTimeout() {
throw new Error('boom!'); throw new Error('boom!');
}); }, 1);
}); });
}); });
} }

Loading…
Cancel
Save