Browse Source

net: honor 'enable' flag in .setNoDelay()

Fixes #3096.
v0.9.1-release
Ben Noordhuis 13 years ago
parent
commit
16fca262be
  1. 5
      lib/net.js
  2. 3
      src/tcp_wrap.cc

5
lib/net.js

@ -183,9 +183,10 @@ Socket.prototype._onTimeout = function() {
};
Socket.prototype.setNoDelay = function() {
Socket.prototype.setNoDelay = function(enable) {
// backwards compatibility: assume true when `enable` is omitted
if (this._handle && this._handle.setNoDelay)
this._handle.setNoDelay();
this._handle.setNoDelay(typeof enable === 'undefined' ? true : !!enable);
};

3
src/tcp_wrap.cc

@ -253,7 +253,8 @@ Handle<Value> TCPWrap::SetNoDelay(const Arguments& args) {
UNWRAP
int r = uv_tcp_nodelay(&wrap->handle_, 1);
int enable = static_cast<int>(args[0]->BooleanValue());
int r = uv_tcp_nodelay(&wrap->handle_, enable);
if (r)
SetErrno(uv_last_error(uv_default_loop()));

Loading…
Cancel
Save