From 17883dfaafd9ffa257cefc30f37bdbd7bfa023d0 Mon Sep 17 00:00:00 2001 From: Gireesh Punathil Date: Wed, 13 Jul 2016 02:03:55 -0400 Subject: [PATCH] test: avoid usage of mixed IPV6 addresses The test case fails in AIX due to the mixed-use of unspecified and loopback addresses. This is not a problem in most platforms but fails in AIX. (In Windows too, but does not manifest as the test is omitted in Windows for a different reason). There exists no documented evidence which supports the mixed use of unspecified and loopback addresses. While AIX strictly follows the IPV6 specification with respect to unspecified address ('::') and loopback address ('::1'), the test case latches on to the behavior exhibited by other platforms, and hence it fails in AIX. The proposed fix is to make it work in all platforms including AIX by using the loopback address for the client to connect, as that is the address at which the server listens. Fixes: https://github.com/nodejs/node/issues/7563 PR-URL: https://github.com/nodejs/node/pull/7702 Reviewed-By: Michael Dawson Reviewed-By: Rich Trott Reviewed-By: Ben Noordhuis Reviewed-By: Colin Ihrig --- test/parallel/test-cluster-disconnect-handles.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/parallel/test-cluster-disconnect-handles.js b/test/parallel/test-cluster-disconnect-handles.js index 49b8218ab9..680e316cf0 100644 --- a/test/parallel/test-cluster-disconnect-handles.js +++ b/test/parallel/test-cluster-disconnect-handles.js @@ -92,7 +92,7 @@ if (cluster.isMaster) { debugger; }; if (common.hasIPv6) - server.listen(cb); + server.listen(0, '::1', cb); else server.listen(0, common.localhostIPv4, cb); process.on('disconnect', process.exit);