Browse Source

test: added net.connect lookup type check

Check the options passed to Socket.prototype.connect() to
validate the type of the lookup property.

PR-URL: https://github.com/nodejs/node/pull/11873
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
v6.x
Luca Maraschi 8 years ago
committed by Myles Borins
parent
commit
186c0758b3
No known key found for this signature in database GPG Key ID: 933B01F40B5CA946
  1. 34
      test/parallel/test-net-options-lookup.js

34
test/parallel/test-net-options-lookup.js

@ -0,0 +1,34 @@
'use strict';
const common = require('../common');
const assert = require('assert');
const net = require('net');
const expectedError = /^TypeError: "lookup" option should be a function$/;
['foobar', 1, {}, []].forEach((input) => connectThrows(input));
function connectThrows(input) {
const opts = {
host: 'localhost',
port: common.PORT,
lookup: input
};
assert.throws(function() {
net.connect(opts);
}, expectedError);
}
[() => {}].forEach((input) => connectDoesNotThrow(input));
function connectDoesNotThrow(input) {
const opts = {
host: 'localhost',
port: common.PORT,
lookup: input
};
assert.doesNotThrow(function() {
net.connect(opts);
});
}
Loading…
Cancel
Save