Browse Source

test: enable setuid/setgid test

Refactor test for situations where it was expected to fail.
Move from disabled directory to parallel.

PR-URL: https://github.com/nodejs/node/pull/12403
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
v6
Rich Trott 8 years ago
parent
commit
189afc8dc2
  1. 56
      test/parallel/test-process-setuid-setgid.js

56
test/disabled/test-setuidgid.js → test/parallel/test-process-setuid-setgid.js

@ -20,25 +20,49 @@
// USE OR OTHER DEALINGS IN THE SOFTWARE. // USE OR OTHER DEALINGS IN THE SOFTWARE.
'use strict'; 'use strict';
// Requires special privileges
const common = require('../common'); const common = require('../common');
const assert = require('assert'); const assert = require('assert');
var oldgid = process.getgid(); if (common.isWindows) {
process.setgid('nobody'); // uid/gid functions are POSIX only
var newgid = process.getgid(); assert.strictEqual(process.getuid, undefined);
assert.notStrictEqual(newgid, oldgid, 'gids expected to be different'); assert.strictEqual(process.setuid, undefined);
assert.strictEqual(process.getgid, undefined);
assert.strictEqual(process.setgid, undefined);
return;
}
var olduid = process.getuid(); assert.throws(() => {
process.setuid('nobody'); process.setuid('fhqwhgadshgnsdhjsdbkhsdabkfabkveybvf');
var newuid = process.getuid(); }, /^Error: setuid user id does not exist$/);
assert.notStrictEqual(newuid, olduid, 'uids expected to be different');
// If we're not running as super user...
try { if (process.getuid() !== 0) {
process.setuid('nobody1234'); assert.doesNotThrow(() => {
} catch (e) { process.getgid();
assert.strictEqual(e.message, process.getuid();
'failed to resolve group', });
'unexpected error message'
assert.throws(
() => { process.setgid('nobody'); },
/^Error: (EPERM, .+|setgid group id does not exist)$/
); );
assert.throws(
() => { process.setuid('nobody'); },
/^Error: EPERM, /
);
return;
} }
// If we are running as super user...
const oldgid = process.getgid();
process.setgid('nobody');
const newgid = process.getgid();
assert.notStrictEqual(newgid, oldgid);
const olduid = process.getuid();
process.setuid('nobody');
const newuid = process.getuid();
assert.notStrictEqual(newuid, olduid);
Loading…
Cancel
Save