Browse Source

test: make flaky pummel test more reliable

Increase the number of iterations from 1e4 to 1e5.  Makes the test pass
for me locally when previously it would fail 9 out of 10 times because
the running time was not enough to smooth away the outliers.

Fixes: https://github.com/nodejs/node/issues/8744
PR-URL: https://github.com/nodejs/node/pull/9241
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: not-an-aardvark <not-an-aardvark@users.noreply.github.com>
v6.x
Ben Noordhuis 8 years ago
committed by Myles Borins
parent
commit
18a235b9a7
  1. 2
      test/pummel/test-crypto-timing-safe-equal-benchmarks.js

2
test/pummel/test-crypto-timing-safe-equal-benchmarks.js

@ -28,7 +28,7 @@ function runOneBenchmark(...args) {
}
function getTValue(compareFunc) {
const numTrials = 10000;
const numTrials = 1e5;
const bufSize = 10000;
// Perform benchmarks to verify that timingSafeEqual is actually timing-safe.

Loading…
Cancel
Save