Browse Source

dgram: call send callback asynchronously

dgram#send callback was changed synchronously.
The PR-URL is here https://github.com/joyent/libuv/pull/1358

This commit is temporary fix until libuv issue is resolved.
https://github.com/libuv/libuv/issues/301

PR-URL: https://github.com/iojs/io.js/pull/1313
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
v2.0.2
Yosuke Furukawa 10 years ago
parent
commit
18d457bd34
  1. 5
      lib/dgram.js
  2. 38
      test/parallel/test-dgram-send-callback-recursive.js

5
lib/dgram.js

@ -337,7 +337,10 @@ function afterSend(err) {
if (err) {
err = exceptionWithHostPort(err, 'send', this.address, this.port);
}
this.callback(err, this.length);
var self = this;
setImmediate(function() {
self.callback(err, self.length);
});
}

38
test/parallel/test-dgram-send-callback-recursive.js

@ -0,0 +1,38 @@
'use strict';
const common = require('../common');
const assert = require('assert');
const dgram = require('dgram');
const client = dgram.createSocket('udp4');
const chunk = 'abc';
var recursiveCount = 0;
var received = 0;
const limit = 10;
function onsend() {
if (recursiveCount > limit) {
throw new Error('infinite loop detected');
}
if (received < limit) {
client.send(
chunk, 0, chunk.length, common.PORT, common.localhostIPv4, onsend);
}
recursiveCount++;
}
client.on('listening', function() {
onsend();
});
client.on('message', function(buf, info) {
received++;
if (received === limit) {
client.close();
}
});
client.on('close', common.mustCall(function() {
assert.equal(received, limit);
}));
client.bind(common.PORT);
Loading…
Cancel
Save