Browse Source

dgram: handle close of dgram socket before DNS lookup completes

v0.8.7-release
Seth Fitzsimmons 13 years ago
committed by Ben Noordhuis
parent
commit
1ce14eca44
  1. 2
      lib/dgram.js
  2. 35
      test/simple/test-dgram-close.js

2
lib/dgram.js

@ -175,7 +175,7 @@ Socket.prototype.send = function(buffer,
if (callback) callback(err); if (callback) callback(err);
self.emit('error', err); self.emit('error', err);
} }
else { else if (self._handle) {
var req = self._handle.send(buffer, offset, length, port, ip); var req = self._handle.send(buffer, offset, length, port, ip);
if (req) { if (req) {
req.oncomplete = afterSend; req.oncomplete = afterSend;

35
test/simple/test-dgram-close.js

@ -0,0 +1,35 @@
// Copyright Joyent, Inc. and other Node contributors.
//
// Permission is hereby granted, free of charge, to any person obtaining a
// copy of this software and associated documentation files (the
// "Software"), to deal in the Software without restriction, including
// without limitation the rights to use, copy, modify, merge, publish,
// distribute, sublicense, and/or sell copies of the Software, and to permit
// persons to whom the Software is furnished to do so, subject to the
// following conditions:
//
// The above copyright notice and this permission notice shall be included
// in all copies or substantial portions of the Software.
//
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
// OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
// MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN
// NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM,
// DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR
// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
// USE OR OTHER DEALINGS IN THE SOFTWARE.
// Ensure that if a dgram socket is closed before the DNS lookup completes, it
// won't crash.
var assert = require('assert'),
common = require('../common'),
dgram = require('dgram');
var buf = new Buffer(1024);
buf.fill(42);
var socket = dgram.createSocket('udp4');
socket.send(buf, 0, buf.length, common.port, 'localhost');
socket.close();
Loading…
Cancel
Save