Browse Source

test: fix flaky test-net-can-reset-timeout

Use `.once()` rather than `.on()` for timeout listener.

Add comment with URL for issue explaining the purpose of the test. (h/t
refack)

PR-URL: https://github.com/nodejs/node/pull/14257
Fixes: https://github.com/nodejs/node/issues/14241
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
v6.x
Rich Trott 8 years ago
committed by Myles Borins
parent
commit
1e403902ba
No known key found for this signature in database GPG Key ID: 933B01F40B5CA946
  1. 5
      test/parallel/test-net-can-reset-timeout.js

5
test/parallel/test-net-can-reset-timeout.js

@ -1,5 +1,8 @@
'use strict';
const common = require('../common');
// Ref: https://github.com/nodejs/node-v0.x-archive/issues/481
const net = require('net');
const server = net.createServer(common.mustCall(function(stream) {
@ -7,7 +10,7 @@ const server = net.createServer(common.mustCall(function(stream) {
stream.resume();
stream.on('timeout', common.mustCall(function() {
stream.once('timeout', common.mustCall(function() {
console.log('timeout');
// try to reset the timeout.
stream.write('WHAT.');

Loading…
Cancel
Save