Browse Source

deps: update http-parser to version 1.2

Fixes http-parser regression with IS_HEADER_CHAR check
Add test case for obstext characters (> 0x80) in header

PR-URL: https://github.com/nodejs/node/pull/5242
Reviewed-By: Rod Vagg <rod@vagg.org>
v0.10
James M Snell 9 years ago
committed by Rod Vagg
parent
commit
1e45a6111c
  1. 2
      deps/http_parser/http_parser.c
  2. 2
      deps/http_parser/http_parser.h
  3. 16
      test/simple/test-http-header-obstext.js

2
deps/http_parser/http_parser.c

@ -388,7 +388,7 @@ enum http_host_state
#endif #endif
#define IS_HEADER_CHAR(ch) \ #define IS_HEADER_CHAR(ch) \
(ch == CR || ch == LF || ch == 9 || (ch > 31 && ch != 127)) (ch == CR || ch == LF || ch == 9 || ((unsigned char)ch > 31 && ch != 127))
#define start_state (parser->type == HTTP_REQUEST ? s_start_req : s_start_res) #define start_state (parser->type == HTTP_REQUEST ? s_start_req : s_start_res)

2
deps/http_parser/http_parser.h

@ -25,7 +25,7 @@ extern "C" {
#endif #endif
#define HTTP_PARSER_VERSION_MAJOR 1 #define HTTP_PARSER_VERSION_MAJOR 1
#define HTTP_PARSER_VERSION_MINOR 1 #define HTTP_PARSER_VERSION_MINOR 2
#include <sys/types.h> #include <sys/types.h>
#if defined(_WIN32) && !defined(__MINGW32__) && (!defined(_MSC_VER) || _MSC_VER<1600) #if defined(_WIN32) && !defined(__MINGW32__) && (!defined(_MSC_VER) || _MSC_VER<1600)

16
test/simple/test-http-header-obstext.js

@ -0,0 +1,16 @@
var common = require('../common');
var http = require('http');
var assert = require('assert');
var server = http.createServer(common.mustCall(function(req, res) {
res.end('ok');
}));
server.listen(common.PORT, function() {
http.get({
port: common.PORT,
headers: {'Test': 'Düsseldorf'}
}, common.mustCall(function(res) {
assert.equal(res.statusCode, 200);
server.close();
}));
});
Loading…
Cancel
Save