Browse Source

test: fix non-determinism in test-crypto-domains

The test implicitly assumed that crypto operations complete in the same
order as they are started but, because they go round-trip through the
thread pool, there is no such guarantee.  Enforce proper sequencing.

Fixes node-forward/node#22.

PR-URL: https://github.com/node-forward/node/pull/23
Reviewed-By: Fedor Indutny <fedor@indutny.com>
archived-io.js-v0.12
Ben Noordhuis 10 years ago
parent
commit
1f11983350
  1. 38
      test/simple/test-crypto-domains.js

38
test/simple/test-crypto-domains.js

@ -24,21 +24,37 @@ var domain = require('domain');
var assert = require('assert'); var assert = require('assert');
var d = domain.create(); var d = domain.create();
var expect = ['pbkdf2', 'randomBytes', 'pseudoRandomBytes'] var expect = ['pbkdf2', 'randomBytes', 'pseudoRandomBytes']
var errors = 0;
process.on('exit', function() {
assert.equal(errors, 3);
});
d.on('error', function (e) { d.on('error', function (e) {
assert.equal(e.message, expect.shift()); assert.equal(e.message, expect.shift());
errors += 1;
}); });
d.run(function () { d.run(function () {
crypto.pbkdf2('a', 'b', 1, 8, function () { one();
throw new Error('pbkdf2');
}); function one() {
crypto.pbkdf2('a', 'b', 1, 8, function () {
crypto.randomBytes(4, function () { two();
throw new Error('randomBytes'); throw new Error('pbkdf2');
}); });
}
crypto.pseudoRandomBytes(4, function () {
throw new Error('pseudoRandomBytes'); function two() {
}); crypto.randomBytes(4, function () {
three();
throw new Error('randomBytes');
});
}
function three() {
crypto.pseudoRandomBytes(4, function () {
throw new Error('pseudoRandomBytes');
});
}
}); });

Loading…
Cancel
Save