From 2055fd371f8f128c3c8bc03113bdf5e7154ab53a Mon Sep 17 00:00:00 2001 From: RobotMermaid Date: Sat, 22 Apr 2017 13:22:16 -0700 Subject: [PATCH] test: cleanup test-util-inherits.js Replaced constructor with regular expression for assert.throw(). PR-URL: https://github.com/nodejs/node/pull/12602 Reviewed-By: Santiago Gimeno Reviewed-By: Anna Henningsen Reviewed-By: James M Snell Reviewed-By: Rich Trott --- test/parallel/test-util-inherits.js | 16 +++++++++++++--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/test/parallel/test-util-inherits.js b/test/parallel/test-util-inherits.js index a3c5786fe2..4ddf9ad35d 100644 --- a/test/parallel/test-util-inherits.js +++ b/test/parallel/test-util-inherits.js @@ -3,6 +3,10 @@ require('../common'); const assert = require('assert'); const inherits = require('util').inherits; +const errCheck = + new RegExp('^TypeError: The super constructor to "inherits" must not be ' + + 'null or undefined$'); + // super constructor function A() { @@ -75,6 +79,12 @@ assert.strictEqual(e.e(), 'e'); assert.strictEqual(e.constructor, E); // should throw with invalid arguments -assert.throws(function() { inherits(A, {}); }, TypeError); -assert.throws(function() { inherits(A, null); }, TypeError); -assert.throws(function() { inherits(null, A); }, TypeError); +assert.throws(function() { + inherits(A, {}); +}, /^TypeError: The super constructor to "inherits" must have a prototype$/); +assert.throws(function() { + inherits(A, null); +}, errCheck); +assert.throws(function() { + inherits(null, A); +}, /^TypeError: The constructor to "inherits" must not be null or undefined$/);