Browse Source

inspector: add missing virtual destructor

This fixes a resource leak detected by a Coverity scan.

PR-URL: https://github.com/nodejs/node/pull/13198
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Aleksei Koziatinskii <ak239spb@gmail.com>
v6
Eugene Ostroukhov 8 years ago
committed by Anna Henningsen
parent
commit
21c0c0275a
No known key found for this signature in database GPG Key ID: D8B9F5AEAE84E4CF
  1. 2
      src/inspector_agent.cc
  2. 1
      src/inspector_agent.h

2
src/inspector_agent.cc

@ -195,7 +195,7 @@ class JsBindingsSessionDelegate : public InspectorSessionDelegate {
v8::WeakCallbackType::kParameter);
}
virtual ~JsBindingsSessionDelegate() {
~JsBindingsSessionDelegate() override {
session_.Reset();
receiver_.Reset();
callback_.Reset();

1
src/inspector_agent.h

@ -37,6 +37,7 @@ namespace inspector {
class InspectorSessionDelegate {
public:
virtual ~InspectorSessionDelegate() = default;
virtual bool WaitForFrontendMessage() = 0;
virtual void OnMessage(const v8_inspector::StringView& message) = 0;
};

Loading…
Cancel
Save