mirror of https://github.com/lukechilds/node.git
Browse Source
PR-URL: https://github.com/nodejs/node/pull/15056 Fixes: https://github.com/nodejs/node/issues/14012 Refs: https://github.com/nodejs/node/pull/14013 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>canary-base
Refael Ackermann
7 years ago
3 changed files with 24 additions and 19 deletions
@ -1,28 +1,33 @@ |
|||||
'use strict'; |
'use strict'; |
||||
const common = require('../common'); |
const common = require('../common'); |
||||
const assert = require('assert'); |
const assert = require('assert'); |
||||
const http = require('http'); |
const { createServer, get } = require('http'); |
||||
const spawn = require('child_process').spawn; |
const { spawn } = require('child_process'); |
||||
|
|
||||
if (process.argv[2] === 'child') { |
if (process.argv[2] === 'child') { |
||||
const server = http.createServer(common.mustCall((req, res) => { |
// sub-process
|
||||
res.end('hello'); |
const server = createServer(common.mustCall((_, res) => res.end('h'))); |
||||
})); |
|
||||
|
|
||||
server.listen(0, common.mustCall((s) => { |
server.listen(0, common.mustCall((s) => { |
||||
const rr = http.get( |
const rr = get({ port: server.address().port }, common.mustCall(() => { |
||||
{ port: server.address().port }, |
// This bad input (0) should abort the parser and the process
|
||||
common.mustCall((d) => { |
rr.parser.consume(0); |
||||
// This bad input (0) should abort the parser and the process
|
// This line should be unreachanble.
|
||||
rr.parser.consume(0); |
assert.fail('this should be unreachable'); |
||||
server.close(); |
})); |
||||
})); |
|
||||
})); |
})); |
||||
} else { |
} else { |
||||
const child = spawn(process.execPath, [__filename, 'child'], |
// super-proces
|
||||
{ stdio: 'inherit' }); |
const child = spawn(process.execPath, [__filename, 'child']); |
||||
|
child.stdout.on('data', common.mustNotCall()); |
||||
|
|
||||
|
let stderr = ''; |
||||
|
child.stderr.on('data', common.mustCallAtLeast((data) => { |
||||
|
assert(Buffer.isBuffer(data)); |
||||
|
stderr += data.toString('utf8'); |
||||
|
}, 1)); |
||||
child.on('exit', common.mustCall((code, signal) => { |
child.on('exit', common.mustCall((code, signal) => { |
||||
assert(common.nodeProcessAborted(code, signal), |
assert(stderr.includes('failed'), `stderr: ${stderr}`); |
||||
'process should have aborted, but did not'); |
const didAbort = common.nodeProcessAborted(code, signal); |
||||
|
assert(didAbort, `process did not abort, code:${code} signal:${signal}`); |
||||
})); |
})); |
||||
} |
} |
||||
|
Loading…
Reference in new issue