From 2486273c0e2e688f9dbb2ef6cdaefe89d75451b5 Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Mon, 21 Nov 2016 13:13:58 -0800 Subject: [PATCH] test: fix flaky test-inspector Using `socket.destroy()` instead of `socket.end()` fixes more-than-intermittent ECONNRESET issues on Windows. PR-URL: https://github.com/nodejs/node/pull/9727 Fixes: https://github.com/nodejs/node/issues/8804 Reviewed-By: Gibson Fahnestock Reviewed-By: Eugene Ostroukhov --- test/inspector/inspector-helper.js | 2 +- test/inspector/inspector.status | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/test/inspector/inspector-helper.js b/test/inspector/inspector-helper.js index a02b6b9a5b..3e517123fe 100644 --- a/test/inspector/inspector-helper.js +++ b/test/inspector/inspector-helper.js @@ -286,7 +286,7 @@ TestSession.prototype.disconnect = function(childDone) { this.expectClose_ = true; this.harness_.childInstanceDone = this.harness_.childInstanceDone || childDone; - this.socket_.end(); + this.socket_.destroy(); console.log('[test]', 'Connection terminated'); callback(); }); diff --git a/test/inspector/inspector.status b/test/inspector/inspector.status index 69865843c9..ed6a782b90 100644 --- a/test/inspector/inspector.status +++ b/test/inspector/inspector.status @@ -7,4 +7,3 @@ prefix inspector [true] # This section applies to all platforms [$system==win32] -test-inspector : PASS,FLAKY