Browse Source

test: move some test from sequential to parallel

The only test with modifications is `test-stdin-child-proc` that was
passing when it should not because the exit code of the child process
was not being checked.

PR-URL: https://github.com/nodejs/node/pull/6087
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com>
v4.x
Santiago Gimeno 9 years ago
committed by Myles Borins
parent
commit
25d4b5b1e9
  1. 0
      test/parallel/test-debug-args.js
  2. 0
      test/parallel/test-force-repl.js
  3. 0
      test/parallel/test-net-localport.js
  4. 0
      test/parallel/test-regress-GH-1531.js
  5. 1
      test/parallel/test-regress-GH-1899.js
  6. 0
      test/parallel/test-regress-GH-4948.js
  7. 1
      test/parallel/test-regress-GH-746.js
  8. 0
      test/parallel/test-socket-write-after-fin-error.js
  9. 0
      test/parallel/test-socket-write-after-fin.js
  10. 13
      test/parallel/test-stdin-child-proc.js
  11. 1
      test/parallel/test-stdin-pipe-resume.js
  12. 0
      test/parallel/test-stdin-script-child.js
  13. 0
      test/parallel/test-stdout-cannot-be-closed-child-process-pipe.js
  14. 0
      test/parallel/test-stdout-to-file.js
  15. 0
      test/parallel/test-sync-fileread.js
  16. 0
      test/parallel/test-vm-syntax-error-stderr.js
  17. 1
      test/parallel/test-zerolengthbufferbug.js
  18. 8
      test/sequential/test-stdin-child-proc.js

0
test/sequential/test-debug-args.js → test/parallel/test-debug-args.js

0
test/sequential/test-force-repl.js → test/parallel/test-force-repl.js

0
test/sequential/test-net-localport.js → test/parallel/test-net-localport.js

0
test/sequential/test-regress-GH-1531.js → test/parallel/test-regress-GH-1531.js

1
test/sequential/test-regress-GH-1899.js → test/parallel/test-regress-GH-1899.js

@ -17,4 +17,3 @@ child.on('exit', function(code, signal) {
assert.equal(code, 0);
assert.equal(output, 'hello, world!\n');
});

0
test/sequential/test-regress-GH-4948.js → test/parallel/test-regress-GH-4948.js

1
test/sequential/test-regress-GH-746.js → test/parallel/test-regress-GH-746.js

@ -27,4 +27,3 @@ server.listen(common.PORT, function() {
process.on('exit', function() {
assert.ok(accepted);
});

0
test/sequential/test-socket-write-after-fin-error.js → test/parallel/test-socket-write-after-fin-error.js

0
test/sequential/test-socket-write-after-fin.js → test/parallel/test-socket-write-after-fin.js

13
test/parallel/test-stdin-child-proc.js

@ -0,0 +1,13 @@
'use strict';
// This tests that pausing and resuming stdin does not hang and timeout
// when done in a child process. See test/parallel/test-stdin-pause-resume.js
const common = require('../common');
const assert = require('assert');
const child_process = require('child_process');
const path = require('path');
const cp = child_process.spawn(process.execPath,
[path.resolve(__dirname, 'test-stdin-pause-resume.js')]);
cp.on('exit', common.mustCall((code) => {
assert.equal(code, 0);
}));

1
test/sequential/test-stdin-pipe-resume.js → test/parallel/test-stdin-pipe-resume.js

@ -25,4 +25,3 @@ if (process.argv[2] === 'child') {
child.stdin.end();
}, 10);
}

0
test/sequential/test-stdin-script-child.js → test/parallel/test-stdin-script-child.js

0
test/sequential/test-stdout-cannot-be-closed-child-process-pipe.js → test/parallel/test-stdout-cannot-be-closed-child-process-pipe.js

0
test/sequential/test-stdout-to-file.js → test/parallel/test-stdout-to-file.js

0
test/sequential/test-sync-fileread.js → test/parallel/test-sync-fileread.js

0
test/sequential/test-vm-syntax-error-stderr.js → test/parallel/test-vm-syntax-error-stderr.js

1
test/sequential/test-zerolengthbufferbug.js → test/parallel/test-zerolengthbufferbug.js

@ -34,4 +34,3 @@ process.on('exit', function() {
assert.ok(gotResponse);
assert.equal(0, resBodySize);
});

8
test/sequential/test-stdin-child-proc.js

@ -1,8 +0,0 @@
'use strict';
// This tests that pausing and resuming stdin does not hang and timeout
// when done in a child process. See test/simple/test-stdin-pause-resume.js
require('../common');
var child_process = require('child_process');
var path = require('path');
child_process.spawn(process.execPath,
[path.resolve(__dirname, 'test-stdin-pause-resume.js')]);
Loading…
Cancel
Save