mirror of https://github.com/lukechilds/node.git
Browse Source
This helps to prevent issues where a failed test can keep a bound socket open long enough to cause other tests to fail with EADDRINUSE because the same port number is used. PR-URL: https://github.com/nodejs/node/pull/7045 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org>v7.x
Brian White
9 years ago
358 changed files with 1554 additions and 1516 deletions
@ -1,86 +1,86 @@ |
|||
'use strict'; |
|||
var common = require('../common'); |
|||
require('../common'); |
|||
var assert = require('assert'); |
|||
var http = require('http'); |
|||
|
|||
var server = http.createServer(function(req, res) { |
|||
res.writeHead(200, {'Content-Type': 'text/plain'}); |
|||
res.end('Hello World\n'); |
|||
}).listen(common.PORT); |
|||
}).listen(0, function() { |
|||
var agent = new http.Agent({maxSockets: 1}); |
|||
|
|||
var agent = new http.Agent({maxSockets: 1}); |
|||
|
|||
agent.on('free', function(socket, host, port) { |
|||
console.log('freeing socket. destroyed? ', socket.destroyed); |
|||
}); |
|||
agent.on('free', function(socket, host, port) { |
|||
console.log('freeing socket. destroyed? ', socket.destroyed); |
|||
}); |
|||
|
|||
var requestOptions = { |
|||
agent: agent, |
|||
host: 'localhost', |
|||
port: common.PORT, |
|||
path: '/' |
|||
}; |
|||
var requestOptions = { |
|||
agent: agent, |
|||
host: 'localhost', |
|||
port: this.address().port, |
|||
path: '/' |
|||
}; |
|||
|
|||
var request1 = http.get(requestOptions, function(response) { |
|||
// assert request2 is queued in the agent
|
|||
var key = agent.getName(requestOptions); |
|||
assert(agent.requests[key].length === 1); |
|||
console.log('got response1'); |
|||
request1.socket.on('close', function() { |
|||
console.log('request1 socket closed'); |
|||
}); |
|||
response.pipe(process.stdout); |
|||
response.on('end', function() { |
|||
console.log('response1 done'); |
|||
/////////////////////////////////
|
|||
//
|
|||
// THE IMPORTANT PART
|
|||
//
|
|||
// It is possible for the socket to get destroyed and other work
|
|||
// to run before the 'close' event fires because it happens on
|
|||
// nextTick. This example is contrived because it destroys the
|
|||
// socket manually at just the right time, but at Voxer we have
|
|||
// seen cases where the socket is destroyed by non-user code
|
|||
// then handed out again by an agent *before* the 'close' event
|
|||
// is triggered.
|
|||
request1.socket.destroy(); |
|||
var request1 = http.get(requestOptions, function(response) { |
|||
// assert request2 is queued in the agent
|
|||
var key = agent.getName(requestOptions); |
|||
assert(agent.requests[key].length === 1); |
|||
console.log('got response1'); |
|||
request1.socket.on('close', function() { |
|||
console.log('request1 socket closed'); |
|||
}); |
|||
response.pipe(process.stdout); |
|||
response.on('end', function() { |
|||
console.log('response1 done'); |
|||
/////////////////////////////////
|
|||
//
|
|||
// THE IMPORTANT PART
|
|||
//
|
|||
// It is possible for the socket to get destroyed and other work
|
|||
// to run before the 'close' event fires because it happens on
|
|||
// nextTick. This example is contrived because it destroys the
|
|||
// socket manually at just the right time, but at Voxer we have
|
|||
// seen cases where the socket is destroyed by non-user code
|
|||
// then handed out again by an agent *before* the 'close' event
|
|||
// is triggered.
|
|||
request1.socket.destroy(); |
|||
|
|||
response.once('close', function() { |
|||
// assert request2 was removed from the queue
|
|||
assert(!agent.requests[key]); |
|||
console.log("waiting for request2.onSocket's nextTick"); |
|||
process.nextTick(function() { |
|||
// assert that the same socket was not assigned to request2,
|
|||
// since it was destroyed.
|
|||
assert(request1.socket !== request2.socket); |
|||
assert(!request2.socket.destroyed, 'the socket is destroyed'); |
|||
response.once('close', function() { |
|||
// assert request2 was removed from the queue
|
|||
assert(!agent.requests[key]); |
|||
console.log("waiting for request2.onSocket's nextTick"); |
|||
process.nextTick(function() { |
|||
// assert that the same socket was not assigned to request2,
|
|||
// since it was destroyed.
|
|||
assert(request1.socket !== request2.socket); |
|||
assert(!request2.socket.destroyed, 'the socket is destroyed'); |
|||
}); |
|||
}); |
|||
}); |
|||
}); |
|||
}); |
|||
|
|||
var request2 = http.get(requestOptions, function(response) { |
|||
assert(!request2.socket.destroyed); |
|||
assert(request1.socket.destroyed); |
|||
// assert not reusing the same socket, since it was destroyed.
|
|||
assert(request1.socket !== request2.socket); |
|||
console.log('got response2'); |
|||
var gotClose = false; |
|||
var gotResponseEnd = false; |
|||
request2.socket.on('close', function() { |
|||
console.log('request2 socket closed'); |
|||
gotClose = true; |
|||
done(); |
|||
}); |
|||
response.pipe(process.stdout); |
|||
response.on('end', function() { |
|||
console.log('response2 done'); |
|||
gotResponseEnd = true; |
|||
done(); |
|||
}); |
|||
var request2 = http.get(requestOptions, function(response) { |
|||
assert(!request2.socket.destroyed); |
|||
assert(request1.socket.destroyed); |
|||
// assert not reusing the same socket, since it was destroyed.
|
|||
assert(request1.socket !== request2.socket); |
|||
console.log('got response2'); |
|||
var gotClose = false; |
|||
var gotResponseEnd = false; |
|||
request2.socket.on('close', function() { |
|||
console.log('request2 socket closed'); |
|||
gotClose = true; |
|||
done(); |
|||
}); |
|||
response.pipe(process.stdout); |
|||
response.on('end', function() { |
|||
console.log('response2 done'); |
|||
gotResponseEnd = true; |
|||
done(); |
|||
}); |
|||
|
|||
function done() { |
|||
if (gotResponseEnd && gotClose) |
|||
server.close(); |
|||
} |
|||
function done() { |
|||
if (gotResponseEnd && gotClose) |
|||
server.close(); |
|||
} |
|||
}); |
|||
}); |
|||
|
|||
Some files were not shown because too many files changed in this diff
Loading…
Reference in new issue