From 3058f08e645bca41ee0f281ed83a697be1e3c8c4 Mon Sep 17 00:00:00 2001 From: isaacs Date: Wed, 1 May 2013 15:36:09 -0700 Subject: [PATCH] tools: remove unnecessary cpplint rules We don't actually care about header order much, and since we never use stl classes, 'string' isn't an issue for node ever. --- tools/cpplint.py | 14 -------------- 1 file changed, 14 deletions(-) diff --git a/tools/cpplint.py b/tools/cpplint.py index 86154ededa..d7c8e713f9 100644 --- a/tools/cpplint.py +++ b/tools/cpplint.py @@ -2280,11 +2280,6 @@ def CheckIncludeLine(filename, clean_lines, linenum, include_state, error): line = clean_lines.lines[linenum] - # "include" should use the new style "foo/bar.h" instead of just "bar.h" - if _RE_PATTERN_INCLUDE_NEW_STYLE.search(line): - error(filename, linenum, 'build/include', 4, - 'Include the directory when naming .h files') - # we shouldn't include a file more than once. actually, there are a # handful of instances where doing so is okay, but in general it's # not. @@ -2826,15 +2821,6 @@ def CheckForIncludeWhatYouUse(filename, clean_lines, include_state, error, if not line or line[0] == '#': continue - # String is special -- it is a non-templatized type in STL. - m = _RE_PATTERN_STRING.search(line) - if m: - # Don't warn about strings in non-STL namespaces: - # (We check only the first match per line; good enough.) - prefix = line[:m.start()] - if prefix.endswith('std::') or not prefix.endswith('::'): - required[''] = (linenum, 'string') - for pattern, template, header in _re_pattern_algorithm_header: if pattern.search(line): required[header] = (linenum, template)