diff --git a/doc/onboarding.md b/doc/onboarding.md index a44d2170bc..991809df1e 100644 --- a/doc/onboarding.md +++ b/doc/onboarding.md @@ -64,31 +64,37 @@ onboarding session. * will also come more naturally over time - * reviewing: - * primary goal is for the codebase to improve - * secondary (but not far off) is for the person submitting code to succeed - * helps grow the community - * and draws new people into the project - * Review a bit at a time. It is **very important** to not overwhelm newer people. - * it is tempting to micro-optimize / make everything about relative perf, - don't succumb to that temptation. we change v8 a lot more often now, contortions - that are zippy today may be unnecessary in the future - * be aware: your opinion carries a lot of weight! - * nits are fine, but try to avoid stalling the PR - * note that they are nits when you comment - * if they really are stalling nits, fix them yourself on merge (but try to let PR authors know they can fix these) - * improvement doesn't have to come all at once - * minimum wait for comments time - * There is a minimum waiting time which we try to respect for non-trivial changes, so that people who may have important input in such a distributed project are able to respond. - * It may help to set time limits and expectations: - * the collaborators are very distributed so it is unlikely that they will be looking at stuff the same time as you are. - * before merging code: give folks at least one working day to respond: "If no one objects, tomorrow at