Browse Source

src: force line buffering for stderr

SmartOS does not line buffer stderr by default, or at least that is the
behavior on the Node project Jenkins server. Force line buffering. This
resolves the flakiness observed on SmartOS for
test-debug-signal-cluster.

PR-URL: https://github.com/nodejs/node/pull/3701
Fixes: https://github.com/nodejs/node/issues/2476
Refs: https://github.com/nodejs/node/pull/3615
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
v4.x
Rich Trott 9 years ago
committed by Myles Borins
parent
commit
3ca6d750b9
  1. 1
      src/node_main.cc
  2. 1
      test/parallel/parallel.status

1
src/node_main.cc

@ -41,6 +41,7 @@ int wmain(int argc, wchar_t *wargv[]) {
#else #else
// UNIX // UNIX
int main(int argc, char *argv[]) { int main(int argc, char *argv[]) {
setvbuf(stderr, NULL, _IOLBF, 1024);
return node::Start(argc, argv); return node::Start(argc, argv);
} }
#endif #endif

1
test/parallel/parallel.status

@ -18,7 +18,6 @@ test-tick-processor : PASS,FLAKY
[$system==macos] [$system==macos]
[$system==solaris] # Also applies to SmartOS [$system==solaris] # Also applies to SmartOS
test-debug-signal-cluster : PASS,FLAKY
[$system==freebsd] [$system==freebsd]

Loading…
Cancel
Save