From 3de406cc58b9a30455b72e12008bdac4d994ba37 Mon Sep 17 00:00:00 2001 From: Bert Belder Date: Thu, 21 Jul 2011 15:26:10 +0200 Subject: [PATCH] Add tests for process.nextTick bugs on windows These are supposed to pass w/ libuv, so add them to the test-uv tests. --- Makefile | 2 + test/simple/test-next-tick-doesnt-hang.js | 30 +++++++++++++ test/simple/test-next-tick-starvation.js | 52 +++++++++++++++++++++++ 3 files changed, 84 insertions(+) create mode 100644 test/simple/test-next-tick-doesnt-hang.js create mode 100644 test/simple/test-next-tick-starvation.js diff --git a/Makefile b/Makefile index aaddd6e98c..95cb3ce450 100644 --- a/Makefile +++ b/Makefile @@ -160,9 +160,11 @@ UVTEST += simple/test-net-server-try-ports UVTEST += simple/test-net-stream UVTEST += simple/test-net-socket-timeout UVTEST += simple/test-next-tick +UVTEST += simple/test-next-tick-doesnt-hang UVTEST += simple/test-next-tick-errors UVTEST += simple/test-next-tick-ordering UVTEST += simple/test-next-tick-ordering2 +UVTEST += simple/test-next-tick-starvation UVTEST += simple/test-path UVTEST += simple/test-pump-file2tcp UVTEST += simple/test-pump-file2tcp-noexist diff --git a/test/simple/test-next-tick-doesnt-hang.js b/test/simple/test-next-tick-doesnt-hang.js new file mode 100644 index 0000000000..3d26bd3c6b --- /dev/null +++ b/test/simple/test-next-tick-doesnt-hang.js @@ -0,0 +1,30 @@ +// Copyright Joyent, Inc. and other Node contributors. +// +// Permission is hereby granted, free of charge, to any person obtaining a +// copy of this software and associated documentation files (the +// "Software"), to deal in the Software without restriction, including +// without limitation the rights to use, copy, modify, merge, publish, +// distribute, sublicense, and/or sell copies of the Software, and to permit +// persons to whom the Software is furnished to do so, subject to the +// following conditions: +// +// The above copyright notice and this permission notice shall be included +// in all copies or substantial portions of the Software. +// +// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS +// OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF +// MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN +// NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, +// DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR +// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE +// USE OR OTHER DEALINGS IN THE SOFTWARE. + + +/* + * This test verifies that having a single nextTick statement and nothing else + * does not hang the event loop. If this test times out it has failed. + */ + +process.nextTick(function() { + // Nothing +}); diff --git a/test/simple/test-next-tick-starvation.js b/test/simple/test-next-tick-starvation.js new file mode 100644 index 0000000000..bf678a0646 --- /dev/null +++ b/test/simple/test-next-tick-starvation.js @@ -0,0 +1,52 @@ +// Copyright Joyent, Inc. and other Node contributors. +// +// Permission is hereby granted, free of charge, to any person obtaining a +// copy of this software and associated documentation files (the +// "Software"), to deal in the Software without restriction, including +// without limitation the rights to use, copy, modify, merge, publish, +// distribute, sublicense, and/or sell copies of the Software, and to permit +// persons to whom the Software is furnished to do so, subject to the +// following conditions: +// +// The above copyright notice and this permission notice shall be included +// in all copies or substantial portions of the Software. +// +// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS +// OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF +// MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN +// NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, +// DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR +// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE +// USE OR OTHER DEALINGS IN THE SOFTWARE. + +var common = require('../common'); +var assert = require('assert'); + + +var ran = false; +var stop = false; +var start = +new Date(); + +function spin() { + var now = +new Date(); + if (now - start > 100) { + throw new Error('The timer is starving'); + } + + if (!stop) { + ran = true; + process.nextTick(spin); + } +} + +function onTimeout() { + stop = true; +} + +spin(); +setTimeout(onTimeout, 50); + +process.on('exit', function() { + assert.ok(ran); + assert.ok(stop); +});