Browse Source

http: make http.get() accept a URL

http.get() now accepts either a URL (as a string) or an options object.
v0.9.1-release
Adam Malcontenti-Wilson 13 years ago
committed by Ben Noordhuis
parent
commit
4099d1eeba
  1. 18
      doc/api/http.markdown
  2. 5
      lib/http.js
  3. 44
      test/simple/test-http-client-get-url.js

18
doc/api/http.markdown

@ -446,8 +446,10 @@ followed by `response.end()`.
## http.request(options, callback) ## http.request(options, callback)
Node maintains several connections per server to make HTTP requests. Node maintains several connections per server to make HTTP requests.
This function allows one to transparently issue requests. `options` align This function allows one to transparently issue requests.
with [url.parse()](url.html#url.parse).
`options` can be an object or a string. If `options` is a string, it is
automatically parsed with [url.parse()](url.html#url.parse).
Options: Options:
@ -528,18 +530,12 @@ There are a few special headers that should be noted.
## http.get(options, callback) ## http.get(options, callback)
Since most requests are GET requests without bodies, Node provides this Since most requests are GET requests without bodies, Node provides this
convenience method. The only difference between this method and `http.request()` is convenience method. The only difference between this method and `http.request()`
that it sets the method to GET and calls `req.end()` automatically. is that it sets the method to GET and calls `req.end()` automatically.
Example: Example:
var options = { http.get("http://www.google.com/index.html", function(res) {
host: 'www.google.com',
port: 80,
path: '/index.html'
};
http.get(options, function(res) {
console.log("Got response: " + res.statusCode); console.log("Got response: " + res.statusCode);
}).on('error', function(e) { }).on('error', function(e) {
console.log("Got error: " + e.message); console.log("Got error: " + e.message);

5
lib/http.js

@ -22,6 +22,7 @@
var util = require('util'); var util = require('util');
var net = require('net'); var net = require('net');
var stream = require('stream'); var stream = require('stream');
var url = require('url');
var EventEmitter = require('events').EventEmitter; var EventEmitter = require('events').EventEmitter;
var FreeList = require('freelist').FreeList; var FreeList = require('freelist').FreeList;
var HTTPParser = process.binding('http_parser').HTTPParser; var HTTPParser = process.binding('http_parser').HTTPParser;
@ -1571,6 +1572,10 @@ ClientRequest.prototype.clearTimeout = function(cb) {
}; };
exports.request = function(options, cb) { exports.request = function(options, cb) {
if (typeof options === 'string') {
options = url.parse(options);
}
if (options.protocol && options.protocol !== 'http:') { if (options.protocol && options.protocol !== 'http:') {
throw new Error('Protocol:' + options.protocol + ' not supported.'); throw new Error('Protocol:' + options.protocol + ' not supported.');
} }

44
test/simple/test-http-client-get-url.js

@ -0,0 +1,44 @@
// Copyright Joyent, Inc. and other Node contributors.
//
// Permission is hereby granted, free of charge, to any person obtaining a
// copy of this software and associated documentation files (the
// "Software"), to deal in the Software without restriction, including
// without limitation the rights to use, copy, modify, merge, publish,
// distribute, sublicense, and/or sell copies of the Software, and to permit
// persons to whom the Software is furnished to do so, subject to the
// following conditions:
//
// The above copyright notice and this permission notice shall be included
// in all copies or substantial portions of the Software.
//
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
// OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
// MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN
// NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM,
// DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR
// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
// USE OR OTHER DEALINGS IN THE SOFTWARE.
var common = require('../common');
var assert = require('assert');
var http = require('http');
var seen_req = false;
var server = http.createServer(function(req, res) {
assert.equal('GET', req.method);
assert.equal('/foo?bar', req.url);
res.writeHead(200, {'Content-Type': 'text/plain'});
res.write('hello\n');
res.end();
server.close();
seen_req = true;
});
server.listen(common.PORT, function() {
http.get('http://127.0.0.1:' + common.PORT + '/foo?bar');
});
process.on('exit', function() {
assert(seen_req);
});
Loading…
Cancel
Save