From 411695e1d26565c7498992be19731bbea6b6aa58 Mon Sep 17 00:00:00 2001
From: Ben Noordhuis <info@bnoordhuis.nl>
Date: Thu, 12 Oct 2017 12:04:02 +0200
Subject: [PATCH] build: lint benchmark addon

PR-URL: https://github.com/nodejs/node/pull/16160
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
---
 Makefile                                | 1 +
 benchmark/misc/function_call/binding.cc | 9 +++------
 2 files changed, 4 insertions(+), 6 deletions(-)

diff --git a/Makefile b/Makefile
index 755542eb07..ddbfd0f885 100644
--- a/Makefile
+++ b/Makefile
@@ -965,6 +965,7 @@ LINT_CPP_EXCLUDE += $(wildcard test/addons-napi/??_*/*.cc test/addons-napi/??_*/
 LINT_CPP_EXCLUDE += src/tracing/trace_event.h src/tracing/trace_event_common.h
 
 LINT_CPP_FILES = $(filter-out $(LINT_CPP_EXCLUDE), $(wildcard \
+	benchmark/misc/function_call/binding.cc \
 	src/*.c \
 	src/*.cc \
 	src/*.h \
diff --git a/benchmark/misc/function_call/binding.cc b/benchmark/misc/function_call/binding.cc
index 95d2a56de2..289a94ac3e 100644
--- a/benchmark/misc/function_call/binding.cc
+++ b/benchmark/misc/function_call/binding.cc
@@ -1,17 +1,14 @@
 #include <v8.h>
 #include <node.h>
 
-using namespace v8;
-
 static int c = 0;
 
-void Hello(const FunctionCallbackInfo<Value>& args) {
+void Hello(const v8::FunctionCallbackInfo<v8::Value>& args) {
   args.GetReturnValue().Set(c++);
 }
 
-extern "C" void init (Local<Object> target) {
-  HandleScope scope(Isolate::GetCurrent());
+void Initialize(v8::Local<v8::Object> target) {
   NODE_SET_METHOD(target, "hello", Hello);
 }
 
-NODE_MODULE(NODE_GYP_MODULE_NAME, init)
+NODE_MODULE(NODE_GYP_MODULE_NAME, Initialize)