From 446c9cdb027b62e08181190c3389188ab80a0d0e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jo=C3=A3o=20Reis?= Date: Mon, 5 Sep 2016 15:08:03 +0100 Subject: [PATCH] win,build: exit when addons fail to build PR-URL: https://github.com/nodejs/node/pull/8412 Reviewed-By: Ben Noordhuis --- vcbuild.bat | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/vcbuild.bat b/vcbuild.bat index 3588ac0a8e..4248bc4aa8 100644 --- a/vcbuild.bat +++ b/vcbuild.bat @@ -343,12 +343,16 @@ for /d %%F in (test\addons\??_*) do ( ) :: generate "%node_exe%" tools\doc\addon-verify.js +if %errorlevel% neq 0 exit /b %errorlevel% :: building addons +SetLocal EnableDelayedExpansion for /d %%F in (test\addons\*) do ( "%node_exe%" deps\npm\node_modules\node-gyp\bin\node-gyp rebuild ^ --directory="%%F" ^ --nodedir="%cd%" + if !errorlevel! neq 0 exit /b !errorlevel! ) +EndLocal goto run-tests :run-tests