Browse Source

test: updated tls-getcipher test

Changed var to ES6 syntax const/let.
Added common.mustCall function wrapper to all functions
called exactly once.
Changed assert.equal to assert.strictEqual.

PR-URL: https://github.com/nodejs/node/pull/9923
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
v6.x
Ethan Arrowood 8 years ago
committed by Anna Henningsen
parent
commit
47c925a4ac
No known key found for this signature in database GPG Key ID: D8B9F5AEAE84E4CF
  1. 32
      test/parallel/test-tls-getcipher.js

32
test/parallel/test-tls-getcipher.js

@ -1,37 +1,37 @@
'use strict'; 'use strict';
var common = require('../common'); const common = require('../common');
var assert = require('assert');
if (!common.hasCrypto) { if (!common.hasCrypto) {
common.skip('missing crypto'); common.skip('missing crypto');
return; return;
} }
var tls = require('tls'); const assert = require('assert');
const tls = require('tls');
var fs = require('fs'); const fs = require('fs');
var cipher_list = ['AES128-SHA256', 'AES256-SHA256']; const cipher_list = ['AES128-SHA256', 'AES256-SHA256'];
var cipher_version_pattern = /TLS|SSL/; const cipher_version_pattern = /TLS|SSL/;
var options = { const options = {
key: fs.readFileSync(common.fixturesDir + '/keys/agent2-key.pem'), key: fs.readFileSync(common.fixturesDir + '/keys/agent2-key.pem'),
cert: fs.readFileSync(common.fixturesDir + '/keys/agent2-cert.pem'), cert: fs.readFileSync(common.fixturesDir + '/keys/agent2-cert.pem'),
ciphers: cipher_list.join(':'), ciphers: cipher_list.join(':'),
honorCipherOrder: true honorCipherOrder: true
}; };
var server = tls.createServer(options, const server = tls.createServer(options,
common.mustCall(function(cleartextStream) {})); common.mustCall(function(cleartextStream) {}));
server.listen(0, '127.0.0.1', function() { server.listen(0, '127.0.0.1', common.mustCall(function() {
var client = tls.connect({ const client = tls.connect({
host: '127.0.0.1', host: '127.0.0.1',
port: this.address().port, port: this.address().port,
ciphers: cipher_list.join(':'), ciphers: cipher_list.join(':'),
rejectUnauthorized: false rejectUnauthorized: false
}, function() { }, common.mustCall(function() {
var cipher = client.getCipher(); const cipher = client.getCipher();
assert.equal(cipher.name, cipher_list[0]); assert.strictEqual(cipher.name, cipher_list[0]);
assert(cipher_version_pattern.test(cipher.version)); assert(cipher_version_pattern.test(cipher.version));
client.end(); client.end();
server.close(); server.close();
}); }));
}); }));

Loading…
Cancel
Save