diff --git a/deps/v8/include/v8-version.h b/deps/v8/include/v8-version.h index 1c3e60f95e..764cbc55ec 100644 --- a/deps/v8/include/v8-version.h +++ b/deps/v8/include/v8-version.h @@ -11,7 +11,7 @@ #define V8_MAJOR_VERSION 5 #define V8_MINOR_VERSION 0 #define V8_BUILD_NUMBER 71 -#define V8_PATCH_LEVEL 33 +#define V8_PATCH_LEVEL 34 // Use 1 for candidates and 0 otherwise. // (Boolean macro values are not supported by all preprocessors.) diff --git a/deps/v8/src/parsing/pattern-rewriter.cc b/deps/v8/src/parsing/pattern-rewriter.cc index 04b517ebba..768a948863 100644 --- a/deps/v8/src/parsing/pattern-rewriter.cc +++ b/deps/v8/src/parsing/pattern-rewriter.cc @@ -77,7 +77,11 @@ bool Parser::PatternRewriter::IsBindingContext(PatternContext c) const { Parser::PatternRewriter::PatternContext Parser::PatternRewriter::SetAssignmentContextIfNeeded(Expression* node) { PatternContext old_context = context(); - if (node->IsAssignment() && node->AsAssignment()->op() == Token::ASSIGN) { + // AssignmentExpressions may occur in the Initializer position of a + // SingleNameBinding. Such expressions should not prompt a change in the + // pattern's context. + if (node->IsAssignment() && node->AsAssignment()->op() == Token::ASSIGN && + !IsInitializerContext()) { set_context(ASSIGNMENT); } return old_context; diff --git a/deps/v8/test/mjsunit/harmony/destructuring.js b/deps/v8/test/mjsunit/harmony/destructuring.js index b6eb6eab09..e84abd112f 100644 --- a/deps/v8/test/mjsunit/harmony/destructuring.js +++ b/deps/v8/test/mjsunit/harmony/destructuring.js @@ -263,6 +263,63 @@ }()); +(function TestAssignmentExprInInitializers() { + { + let x, y; + { + let { x = y = 1 } = {}; + assertSame(x, 1); + assertSame(y, 1); + } + assertSame(undefined, x); + assertSame(1, y); + } + + { + let x, y; + { + let { x: x = y = 1 } = {}; + assertSame(1, x); + assertSame(1, y); + } + assertSame(undefined, x); + assertSame(1, y); + } + + { + let x, y; + { + let [ x = y = 1 ] = []; + assertSame(1, x); + assertSame(1, y); + } + assertSame(undefined, x); + assertSame(1, y); + } + + { + let x, y; + (function({ x = y = 1 }) {}({})); + assertSame(undefined, x); + assertSame(1, y); + } + + { + let x, y; + (function({ x: x = y = 1 }) {}({})); + assertSame(undefined, x); + assertSame(1, y); + } + + { + let x, y; + (function([ x = y = 1 ]) {}([])); + assertSame(undefined, x); + assertSame(1, y); + } +}()); + + (function TestMultipleAccesses() { assertThrows( "'use strict';"+