From 4c7688138366bc350ed0260583d457733f835828 Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Thu, 15 Sep 2016 22:50:28 -0700 Subject: [PATCH] doc: update exercise portion of onboarding doc MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit PR-URL: https://github.com/nodejs/node/pull/8559 Reviewed-By: Luigi Pinca Reviewed-By: Michaël Zasso Reviewed-By: Gibson Fahnestock Reviewed-By: Ilkka Myller --- doc/onboarding.md | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/doc/onboarding.md b/doc/onboarding.md index f554d5f010..3b0af6b474 100644 --- a/doc/onboarding.md +++ b/doc/onboarding.md @@ -188,14 +188,15 @@ Landing a PR * Close the pull request with a "Landed in ``" comment. -## exercise: make PRs adding yourselves to the README +## Exercise: Make a PR adding yourself to the README * Example: https://github.com/nodejs/node/commit/7b09aade8468e1c930f36b9c81e6ac2ed5bc8732 - * to see full URL: `git log 7b09aade8468e1c930f36b9c81e6ac2ed5bc8732 -1` - * Collaborators in alphabetical order by username - * Label your pull request with the `doc` subsystem label - * If you would like to run CI on your PR, feel free to - * Make sure to added the `PR-URL: `! + * For raw commit message: `git log 7b09aade8468e1c930f36b9c81e6ac2ed5bc8732 -1` + * Collaborators are in alphabetical order by GitHub username. + * Label your pull request with the `doc` subsystem label. + * Run CI on your PR. + * After a `LGTM` or two, land the PR. + * Be sure to add the `PR-URL: ` and appropriate `Reviewed-By:` metadata! ## final notes