From 4c8b244059c9e51a31f843960e702b6fb5ad9fb7 Mon Sep 17 00:00:00 2001 From: cjihrig Date: Wed, 28 Jun 2017 12:44:07 -0400 Subject: [PATCH] test: verify isNativeError accepts internal errors This commit verifies that Node's internal errors are recognized by V8's IsNativeError(), which is exposed in Node as process.binding('util').isNativeError(). PR-URL: https://github.com/nodejs/node/pull/13965 Reviewed-By: Refael Ackermann Reviewed-By: James M Snell Reviewed-By: Evan Lucas Reviewed-By: Anna Henningsen Reviewed-By: Luigi Pinca Reviewed-By: Timothy Gu Reviewed-By: Michael Dawson --- test/parallel/test-util.js | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/test/parallel/test-util.js b/test/parallel/test-util.js index 05c83a18af..191f4361b4 100644 --- a/test/parallel/test-util.js +++ b/test/parallel/test-util.js @@ -20,9 +20,11 @@ // USE OR OTHER DEALINGS IN THE SOFTWARE. 'use strict'; +// Flags: --expose-internals const common = require('../common'); const assert = require('assert'); const util = require('util'); +const errors = require('internal/errors'); const binding = process.binding('util'); const context = require('vm').runInNewContext; @@ -167,4 +169,8 @@ util.error('test'); assert.strictEqual(binding.isNativeError([]), false); assert.strictEqual(binding.isNativeError(Object.create(Error.prototype)), false); + assert.strictEqual( + binding.isNativeError(new errors.Error('ERR_IPC_CHANNEL_CLOSED')), + true + ); }