From 509b59ea7c815a27c623773cee6480667f68293c Mon Sep 17 00:00:00 2001 From: Ben Noordhuis Date: Fri, 27 Mar 2015 12:05:40 +0100 Subject: [PATCH] deps: enable v8 postmortem debugging again Cherry-pick https://codereview.chromium.org/1033733003 from upstream and re-enable postmortem debugging. PR-URL: https://github.com/iojs/io.js/pull/1232 Reviewed-By: Fedor Indutny --- common.gypi | 5 ++--- deps/v8/tools/gen-postmortem-metadata.py | 2 +- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/common.gypi b/common.gypi index 8aee4eaaf7..ea7779ee09 100644 --- a/common.gypi +++ b/common.gypi @@ -20,17 +20,16 @@ # Enable disassembler for `--print-code` v8 options 'v8_enable_disassembler': 1, - # Disable support for postmortem debugging, continuously broken. - 'v8_postmortem_support%': 'false', - # Don't bake anything extra into the snapshot. 'v8_use_external_startup_data%': 0, 'conditions': [ ['OS == "win"', { 'os_posix': 0, + 'v8_postmortem_support%': 'false', }, { 'os_posix': 1, + 'v8_postmortem_support%': 'true', }], ['GENERATOR == "ninja" or OS== "mac"', { 'OBJ_DIR': '<(PRODUCT_DIR)/obj', diff --git a/deps/v8/tools/gen-postmortem-metadata.py b/deps/v8/tools/gen-postmortem-metadata.py index 62e103a735..d5defa7a2a 100644 --- a/deps/v8/tools/gen-postmortem-metadata.py +++ b/deps/v8/tools/gen-postmortem-metadata.py @@ -91,7 +91,7 @@ consts_misc = [ { 'name': 'prop_idx_first', 'value': 'DescriptorArray::kFirstIndex' }, { 'name': 'prop_type_field', - 'value': 'FIELD' }, + 'value': 'DATA' }, { 'name': 'prop_type_mask', 'value': 'PropertyDetails::TypeField::kMask' }, { 'name': 'prop_index_mask',