From 51c8b0ede3a6bdcca44626a004c15eac3a55c87a Mon Sep 17 00:00:00 2001 From: isaacs Date: Wed, 6 Mar 2013 12:58:37 -0800 Subject: [PATCH] V8: Reapply floating patches --- deps/v8/build/common.gypi | 11 +---------- deps/v8/src/platform-posix.cc | 17 +++++++++++++---- deps/v8/src/v8utils.h | 2 ++ deps/v8/tools/gen-postmortem-metadata.py | 15 +++++++++++---- 4 files changed, 27 insertions(+), 18 deletions(-) diff --git a/deps/v8/build/common.gypi b/deps/v8/build/common.gypi index 78888b8d7c..6e0ef0c997 100644 --- a/deps/v8/build/common.gypi +++ b/deps/v8/build/common.gypi @@ -157,7 +157,7 @@ [ 'v8_use_arm_eabi_hardfloat=="true"', { 'defines': [ 'USE_EABI_HARDFLOAT=1', - 'CAN_USE_VFP3_INSTRUCTIONS', + 'CAN_USE_VFP2_INSTRUCTIONS', ], 'target_conditions': [ ['_toolset=="target"', { @@ -378,15 +378,6 @@ 'conditions': [ ['OS=="linux" or OS=="freebsd" or OS=="openbsd" or OS=="netbsd" \ or OS=="android"', { - 'cflags!': [ - '-O2', - '-Os', - ], - 'cflags': [ - '-fdata-sections', - '-ffunction-sections', - '-O3', - ], 'conditions': [ [ 'gcc_version==44 and clang==0', { 'cflags': [ diff --git a/deps/v8/src/platform-posix.cc b/deps/v8/src/platform-posix.cc index 3bc83733ca..2b80015161 100644 --- a/deps/v8/src/platform-posix.cc +++ b/deps/v8/src/platform-posix.cc @@ -109,11 +109,20 @@ void* OS::GetRandomMmapAddr() { raw_addr &= V8_UINT64_C(0x3ffffffff000); #else uint32_t raw_addr = V8::RandomPrivate(isolate); - // The range 0x20000000 - 0x60000000 is relatively unpopulated across a - // variety of ASLR modes (PAE kernel, NX compat mode, etc) and on macos - // 10.6 and 10.7. + + // For our 32-bit mmap() hint, we pick a random address in the bottom + // half of the top half of the address space (that is, the third quarter). + // Because we do not MAP_FIXED, this will be treated only as a hint -- the + // system will not fail to mmap() because something else happens to already + // be mapped at our random address. We deliberately set the hint high enough + // to get well above the system's break (that is, the heap); systems will + // either try the hint and if that fails move higher (MacOS and other BSD + // derivatives) or try the hint and if that fails allocate as if there were + // no hint at all (Linux, Solaris, illumos and derivatives). The high hint + // prevents the break from getting hemmed in at low values, ceding half of + // the address space to the system heap. raw_addr &= 0x3ffff000; - raw_addr += 0x20000000; + raw_addr += 0x80000000; #endif return reinterpret_cast(raw_addr); } diff --git a/deps/v8/src/v8utils.h b/deps/v8/src/v8utils.h index 9072b4e285..111abdf8b8 100644 --- a/deps/v8/src/v8utils.h +++ b/deps/v8/src/v8utils.h @@ -209,6 +209,8 @@ INLINE(void CopyChars(sinkchar* dest, const sourcechar* src, int chars)); template void CopyChars(sinkchar* dest, const sourcechar* src, int chars) { + ASSERT(chars >= 0); + if (chars == 0) return; sinkchar* limit = dest + chars; #ifdef V8_HOST_CAN_READ_UNALIGNED if (sizeof(*dest) == sizeof(*src)) { diff --git a/deps/v8/tools/gen-postmortem-metadata.py b/deps/v8/tools/gen-postmortem-metadata.py index f59cfd3033..7bee763bc9 100644 --- a/deps/v8/tools/gen-postmortem-metadata.py +++ b/deps/v8/tools/gen-postmortem-metadata.py @@ -76,16 +76,23 @@ consts_misc = [ { 'name': 'SmiTag', 'value': 'kSmiTag' }, { 'name': 'SmiTagMask', 'value': 'kSmiTagMask' }, { 'name': 'SmiValueShift', 'value': 'kSmiTagSize' }, + { 'name': 'SmiShiftSize', 'value': 'kSmiShiftSize' }, { 'name': 'PointerSizeLog2', 'value': 'kPointerSizeLog2' }, - { 'name': 'prop_idx_transitions', - 'value': 'DescriptorArray::kTransitionsIndex' }, + { 'name': 'prop_desc_key', + 'value': 'DescriptorArray::kDescriptorKey' }, + { 'name': 'prop_desc_details', + 'value': 'DescriptorArray::kDescriptorDetails' }, + { 'name': 'prop_desc_value', + 'value': 'DescriptorArray::kDescriptorValue' }, + { 'name': 'prop_desc_size', + 'value': 'DescriptorArray::kDescriptorSize' }, { 'name': 'prop_idx_first', 'value': 'DescriptorArray::kFirstIndex' }, { 'name': 'prop_type_field', 'value': 'FIELD' }, { 'name': 'prop_type_first_phantom', - 'value': 'MAP_TRANSITION' }, + 'value': 'Code::MAP_TRANSITION' }, { 'name': 'prop_type_mask', 'value': 'PropertyDetails::TypeField::kMask' }, @@ -107,7 +114,7 @@ extras_accessors = [ 'JSObject, elements, Object, kElementsOffset', 'FixedArray, data, uintptr_t, kHeaderSize', 'Map, instance_attributes, int, kInstanceAttributesOffset', - 'Map, instance_descriptors, int, kInstanceDescriptorsOrBitField3Offset', + 'Map, transitions, uintptr_t, kTransitionsOrBackPointerOffset', 'Map, inobject_properties, int, kInObjectPropertiesOffset', 'Map, instance_size, int, kInstanceSizeOffset', 'HeapNumber, value, double, kValueOffset',