From 526c54c9790cd8edff259686785d7b844fd29005 Mon Sep 17 00:00:00 2001 From: koichik Date: Thu, 8 Sep 2011 11:47:32 +0900 Subject: [PATCH] buffer: write() should always set _charsWritten. Fixes #1633. --- lib/buffer.js | 1 + test/simple/test-buffer.js | 2 ++ 2 files changed, 3 insertions(+) diff --git a/lib/buffer.js b/lib/buffer.js index c8a4eb14ce..91fd67706c 100644 --- a/lib/buffer.js +++ b/lib/buffer.js @@ -122,6 +122,7 @@ SlowBuffer.prototype.hexWrite = function(string, offset, length) { if (isNaN(byte)) throw new Error('Invalid hex string'); this[offset + i] = byte; } + SlowBuffer._charsWritten = i * 2; return i; }; diff --git a/test/simple/test-buffer.js b/test/simple/test-buffer.js index 7850cb2cfd..4152c28b56 100644 --- a/test/simple/test-buffer.js +++ b/test/simple/test-buffer.js @@ -687,3 +687,5 @@ buf.write('0123456789', 'binary'); assert.equal(Buffer._charsWritten, 9); buf.write('123456', 'base64'); assert.equal(Buffer._charsWritten, 6); +buf.write('00010203040506070809', 'hex'); +assert.equal(Buffer._charsWritten, 18);