Browse Source

src: replace deprecated SetWeak in object_wrap

Migrate node_object_wrap.h to the new SetWeak API.

PR-URL: https://github.com/nodejs/node/pull/5494
Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: targos - Michaël Zasso <mic.besace@gmail.com>
process-exit-stdio-flushing
Ali Ijaz Sheikh 9 years ago
committed by Ali Sheikh
parent
commit
536cfecd71
  1. 9
      src/node_object_wrap.h

9
src/node_object_wrap.h

@ -61,7 +61,7 @@ class ObjectWrap {
inline void MakeWeak(void) {
persistent().SetWeak(this, WeakCallback);
persistent().SetWeak(this, WeakCallback, v8::WeakCallbackType::kParameter);
persistent().MarkIndependent();
}
@ -96,14 +96,9 @@ class ObjectWrap {
private:
static void WeakCallback(
const v8::WeakCallbackData<v8::Object, ObjectWrap>& data) {
v8::Isolate* isolate = data.GetIsolate();
v8::HandleScope scope(isolate);
const v8::WeakCallbackInfo<ObjectWrap>& data) {
ObjectWrap* wrap = data.GetParameter();
assert(wrap->refs_ == 0);
assert(wrap->handle_.IsNearDeath());
assert(
data.GetValue() == v8::Local<v8::Object>::New(isolate, wrap->handle_));
wrap->handle_.Reset();
delete wrap;
}

Loading…
Cancel
Save