mirror of https://github.com/lukechilds/node.git
Browse Source
This patch includes tests for sync versions of mkdir and rmdir. Also, it moves the test to `parallel`. PR-URL: https://github.com/nodejs/node/pull/2588 Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Johan Bergström <bugs@bergstroem.nu>v5.x
Sakthipriyan Vairamani
9 years ago
2 changed files with 37 additions and 43 deletions
@ -0,0 +1,37 @@ |
|||||
|
'use strict'; |
||||
|
|
||||
|
const common = require('../common'); |
||||
|
const assert = require('assert'); |
||||
|
const path = require('path'); |
||||
|
const fs = require('fs'); |
||||
|
const d = path.join(common.tmpDir, 'dir'); |
||||
|
|
||||
|
common.refreshTmpDir(); |
||||
|
|
||||
|
// Make sure the directory does not exist
|
||||
|
assert(!common.fileExists(d)); |
||||
|
// Create the directory now
|
||||
|
fs.mkdirSync(d); |
||||
|
// Make sure the directory exists
|
||||
|
assert(common.fileExists(d)); |
||||
|
// Try creating again, it should fail with EEXIST
|
||||
|
assert.throws(function() { |
||||
|
fs.mkdirSync(d); |
||||
|
}, /EEXIST: file already exists, mkdir/); |
||||
|
// Remove the directory now
|
||||
|
fs.rmdirSync(d); |
||||
|
// Make sure the directory does not exist
|
||||
|
assert(!common.fileExists(d)); |
||||
|
|
||||
|
// Similarly test the Async version
|
||||
|
fs.mkdir(d, 0o666, function(err) { |
||||
|
assert.ifError(err); |
||||
|
|
||||
|
fs.mkdir(d, 0o666, function(err) { |
||||
|
assert.ok(err.message.match(/^EEXIST/), 'got EEXIST message'); |
||||
|
assert.equal(err.code, 'EEXIST', 'got EEXIST code'); |
||||
|
assert.equal(err.path, d, 'got proper path for EEXIST'); |
||||
|
|
||||
|
fs.rmdir(d, assert.ifError); |
||||
|
}); |
||||
|
}); |
@ -1,43 +0,0 @@ |
|||||
'use strict'; |
|
||||
var common = require('../common'); |
|
||||
var assert = require('assert'); |
|
||||
var path = require('path'); |
|
||||
var fs = require('fs'); |
|
||||
|
|
||||
common.refreshTmpDir(); |
|
||||
|
|
||||
var dirname = path.dirname(__filename); |
|
||||
var d = path.join(common.tmpDir, 'dir'); |
|
||||
|
|
||||
var mkdir_error = false; |
|
||||
var rmdir_error = false; |
|
||||
|
|
||||
fs.mkdir(d, 0o666, function(err) { |
|
||||
if (err) { |
|
||||
console.log('mkdir error: ' + err.message); |
|
||||
mkdir_error = true; |
|
||||
} else { |
|
||||
fs.mkdir(d, 0o666, function(err) { |
|
||||
console.log('expect EEXIST error: ', err); |
|
||||
assert.ok(err.message.match(/^EEXIST/), 'got EEXIST message'); |
|
||||
assert.equal(err.code, 'EEXIST', 'got EEXIST code'); |
|
||||
assert.equal(err.path, d, 'got proper path for EEXIST'); |
|
||||
|
|
||||
console.log('mkdir okay!'); |
|
||||
fs.rmdir(d, function(err) { |
|
||||
if (err) { |
|
||||
console.log('rmdir error: ' + err.message); |
|
||||
rmdir_error = true; |
|
||||
} else { |
|
||||
console.log('rmdir okay!'); |
|
||||
} |
|
||||
}); |
|
||||
}); |
|
||||
} |
|
||||
}); |
|
||||
|
|
||||
process.on('exit', function() { |
|
||||
assert.equal(false, mkdir_error); |
|
||||
assert.equal(false, rmdir_error); |
|
||||
console.log('exit'); |
|
||||
}); |
|
Loading…
Reference in new issue