Browse Source

test: favor `===` over `==` in crypto tests

PR-URL: https://github.com/nodejs/node/pull/8176
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
v4.x
Rich Trott 8 years ago
committed by Myles Borins
parent
commit
57c98f18a9
  1. 2
      test/parallel/test-crypto-authenticated.js
  2. 2
      test/parallel/test-crypto-hmac.js
  3. 2
      test/pummel/test-crypto-dh.js

2
test/parallel/test-crypto-authenticated.js

@ -312,7 +312,7 @@ var ciphers = crypto.getCiphers();
for (var i in TEST_CASES) {
var test = TEST_CASES[i];
if (ciphers.indexOf(test.algo) == -1) {
if (ciphers.indexOf(test.algo) === -1) {
common.skip('unsupported ' + test.algo + ' test');
continue;
}

2
test/parallel/test-crypto-hmac.js

@ -62,7 +62,7 @@ var wikipedia = [
for (let i = 0, l = wikipedia.length; i < l; i++) {
for (const hash in wikipedia[i]['hmac']) {
// FIPS does not support MD5.
if (common.hasFipsCrypto && hash == 'md5')
if (common.hasFipsCrypto && hash === 'md5')
continue;
const result = crypto.createHmac(hash, wikipedia[i]['key'])
.update(wikipedia[i]['data'])

2
test/pummel/test-crypto-dh.js

@ -42,7 +42,7 @@ for (const name in hashes) {
for (const name in hashes) {
// modp1 is 768 bits, FIPS requires >= 1024
if (name == 'modp1' && common.hasFipsCrypto)
if (name === 'modp1' && common.hasFipsCrypto)
continue;
var group1 = crypto.getDiffieHellman(name);
var group2 = crypto.getDiffieHellman(name);

Loading…
Cancel
Save