From 58ff5a6aa2fc5a895b54b8eecd45c13c4fcc5090 Mon Sep 17 00:00:00 2001
From: Richard Hong <rich.hong@gmail.com>
Date: Sat, 24 Sep 2016 16:14:16 -0700
Subject: [PATCH] test:replace indexOf, assert.equal, add mustCall()

replace indexOf with includes
replace assert.equal with assert.strictEqual
add common.mustCall
replace throw error with assert.ifError

PR-URL: https://github.com/nodejs/node/pull/8766
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
---
 test/parallel/test-fs-symlink.js | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/test/parallel/test-fs-symlink.js b/test/parallel/test-fs-symlink.js
index bac0677b34..ab52ba2292 100644
--- a/test/parallel/test-fs-symlink.js
+++ b/test/parallel/test-fs-symlink.js
@@ -12,7 +12,7 @@ if (common.isWindows) {
   // On Windows, creating symlinks requires admin privileges.
   // We'll only try to run symlink test if we have enough privileges.
   exec('whoami /priv', function(err, o) {
-    if (err || o.indexOf('SeCreateSymbolicLinkPrivilege') == -1) {
+    if (err || !o.includes('SeCreateSymbolicLinkPrivilege')) {
       common.skip('insufficient privileges');
       return;
     }
@@ -25,24 +25,24 @@ common.refreshTmpDir();
 const linkData = path.join(common.fixturesDir, '/cycles/root.js');
 const linkPath = path.join(common.tmpDir, 'symlink1.js');
 
-fs.symlink(linkData, linkPath, function(err) {
-  if (err) throw err;
+fs.symlink(linkData, linkPath, common.mustCall(function(err) {
+  assert.ifError(err);
 
   fs.lstat(linkPath, common.mustCall(function(err, stats) {
-    if (err) throw err;
+    assert.ifError(err);
     linkTime = stats.mtime.getTime();
   }));
 
   fs.stat(linkPath, common.mustCall(function(err, stats) {
-    if (err) throw err;
+    assert.ifError(err);
     fileTime = stats.mtime.getTime();
   }));
 
   fs.readlink(linkPath, common.mustCall(function(err, destination) {
-    if (err) throw err;
-    assert.equal(destination, linkData);
+    assert.ifError(err);
+    assert.strictEqual(destination, linkData);
   }));
-});
+}));
 
 
 process.on('exit', function() {