diff --git a/lib/net.js b/lib/net.js index d57d4c43e9..b6697136d2 100644 --- a/lib/net.js +++ b/lib/net.js @@ -443,6 +443,8 @@ Socket.prototype.write = function(data, arg1, arg2) { Socket.prototype._write = function(data, encoding, cb) { timers.active(this); + if (!this._handle) throw new Error('This socket is closed.'); + // `encoding` is unused right now, `data` is always a buffer. var writeReq = this._handle.write(data); diff --git a/test/simple/test-net-write-after-close.js b/test/simple/test-net-write-after-close.js new file mode 100644 index 0000000000..2edb16d959 --- /dev/null +++ b/test/simple/test-net-write-after-close.js @@ -0,0 +1,43 @@ +// Copyright Joyent, Inc. and other Node contributors. +// +// Permission is hereby granted, free of charge, to any person obtaining a +// copy of this software and associated documentation files (the +// "Software"), to deal in the Software without restriction, including +// without limitation the rights to use, copy, modify, merge, publish, +// distribute, sublicense, and/or sell copies of the Software, and to permit +// persons to whom the Software is furnished to do so, subject to the +// following conditions: +// +// The above copyright notice and this permission notice shall be included +// in all copies or substantial portions of the Software. +// +// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS +// OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF +// MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN +// NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, +// DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR +// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE +// USE OR OTHER DEALINGS IN THE SOFTWARE. + +var common = require('../common'); +var assert = require('assert'); +var net = require('net'); + + +var server = net.createServer(function(socket) { + setTimeout(function() { + assert.throws( + function() { + socket.write('test'); + }, + /This socket is closed/ + ); + process.exit(); + }, 250); +}); + +server.listen(common.PORT, function() { + var client = net.connect(common.PORT, function() { + client.end(); + }); +});