Browse Source

module: return correct exports from linked binding

Method `LinkedBinding` must return the same "exports" property
of the module as cached, because property can be overridden
by an initialization function.

PR-URL: https://github.com/nodejs/node/pull/5337
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
process-exit-stdio-flushing
Phillip Kovalev 9 years ago
committed by Ben Noordhuis
parent
commit
5c14efbbe9
  1. 5
      src/node.cc

5
src/node.cc

@ -2450,9 +2450,10 @@ static void LinkedBinding(const FunctionCallbackInfo<Value>& args) {
return env->ThrowError("Linked module has no declared entry point.");
}
cache->Set(module_name, module->Get(exports_prop));
auto effective_exports = module->Get(exports_prop);
cache->Set(module_name, effective_exports);
args.GetReturnValue().Set(exports);
args.GetReturnValue().Set(effective_exports);
}
static void ProcessTitleGetter(Local<String> property,

Loading…
Cancel
Save