Browse Source

gtest: output tap comments as yamlish

This makes yaml-ish parsers happy.
Note: gtest still seems to output the expected/result slightly
different making the full traceback less informational.

PR-URL: https://github.com/nodejs/node/pull/9262
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
v6
Johan Bergström 8 years ago
parent
commit
6831ebe3bb
  1. 16
      deps/gtest/src/gtest.cc

16
deps/gtest/src/gtest.cc

@ -3596,13 +3596,15 @@ void TapUnitTestResultPrinter::OutputTapTestInfo(int* count,
*stream << " ---\n"; *stream << " ---\n";
*stream << " duration_ms: " << *stream << " duration_ms: " <<
FormatTimeInMillisAsSeconds(result.elapsed_time()) << "\n"; FormatTimeInMillisAsSeconds(result.elapsed_time()) << "\n";
*stream << " ...\n";
for (int i = 0; i < result.total_part_count(); ++i) { if (result.total_part_count() > 0) {
const TestPartResult& part = result.GetTestPartResult(i); *stream << " stack: |-\n";
OutputTapComment(stream, part.message()); for (int i = 0; i < result.total_part_count(); ++i) {
const TestPartResult& part = result.GetTestPartResult(i);
OutputTapComment(stream, part.message());
}
} }
*stream << " ...\n";
*count += 1; *count += 1;
} }
@ -3610,11 +3612,11 @@ void TapUnitTestResultPrinter::OutputTapComment(::std::ostream* stream,
const char* comment) { const char* comment) {
const char* start = comment; const char* start = comment;
while (const char* end = strchr(start, '\n')) { while (const char* end = strchr(start, '\n')) {
*stream << "# " << std::string(start, end) << "\n"; *stream << " " << std::string(start, end) << "\n";
start = end + 1; start = end + 1;
} }
if (*start) if (*start)
*stream << "# " << start << "\n"; *stream << " " << start << "\n";
} }
// Formats the given time in milliseconds as seconds. // Formats the given time in milliseconds as seconds.

Loading…
Cancel
Save