From 6b588007df68b92fb3afe3427189f5954c979176 Mon Sep 17 00:00:00 2001 From: Ben Noordhuis Date: Thu, 9 Aug 2012 01:02:47 +0200 Subject: [PATCH] test: fix pummel/test-net-connect-econnrefused The test relied on a peculiarity of process.nextTick() that was changed in commit 4e5fe2d. Before that commit, each nextTick callback corresponded with the event loop moving forward one tick. That's no longer the case. --- test/pummel/test-net-connect-econnrefused.js | 19 +++++++++---------- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/test/pummel/test-net-connect-econnrefused.js b/test/pummel/test-net-connect-econnrefused.js index bb3ef5945e..86231c73cd 100644 --- a/test/pummel/test-net-connect-econnrefused.js +++ b/test/pummel/test-net-connect-econnrefused.js @@ -27,7 +27,7 @@ var net = require('net'); var ROUNDS = 5; var ATTEMPTS_PER_ROUND = 200; -var rounds = 0; +var rounds = 1; var reqs = 0; pummel(); @@ -39,21 +39,20 @@ function pummel() { net.createConnection(common.PORT).on('error', function(err) { assert.equal(err.code, 'ECONNREFUSED'); if (--pending > 0) return; - if (++rounds < ROUNDS) return pummel(); - check(); + if (rounds == ROUNDS) return check(); + rounds++; + pummel(); }); reqs++; } } function check() { - process.nextTick(function() { - process.nextTick(function() { - assert.equal(process._getActiveRequests().length, 0); - assert.equal(process._getActiveHandles().length, 0); - check_called = true; - }); - }); + setTimeout(function() { + assert.equal(process._getActiveRequests().length, 0); + assert.equal(process._getActiveHandles().length, 1); // the timer + check_called = true; + }, 0); } var check_called = false;