Browse Source

test: improve error messages in test-npm-install

PR-URL: https://github.com/nodejs/node/pull/11027
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
v6
Gonen Dukas 8 years ago
committed by James M Snell
parent
commit
6ca1bdfeb1
  1. 4
      test/parallel/test-npm-install.js

4
test/parallel/test-npm-install.js

@ -53,8 +53,8 @@ const proc = spawn(process.execPath, args, {
}); });
function handleExit(code, signalCode) { function handleExit(code, signalCode) {
assert.strictEqual(code, 0, 'npm install should run without an error'); assert.strictEqual(code, 0, `npm install got error code ${code}`);
assert.ok(signalCode === null, 'signalCode should be null'); assert.strictEqual(signalCode, null, `unexpected signal: ${signalCode}`);
assert.doesNotThrow(function() { assert.doesNotThrow(function() {
fs.accessSync(installDir + '/node_modules/package-name'); fs.accessSync(installDir + '/node_modules/package-name');
}); });

Loading…
Cancel
Save