From 6d842897c5966cee1924b5073e273568923c8693 Mon Sep 17 00:00:00 2001 From: Brian White Date: Thu, 15 Aug 2013 17:55:05 -0400 Subject: [PATCH] lib: remove unused variables and functions --- lib/_debugger.js | 3 +-- lib/_http_agent.js | 4 ---- lib/_http_client.js | 2 -- lib/_http_outgoing.js | 3 --- lib/_stream_readable.js | 1 - lib/_stream_transform.js | 3 +-- lib/_stream_writable.js | 1 - lib/_tls_wrap.js | 3 --- lib/buffer.js | 1 - lib/child_process.js | 6 +----- lib/dgram.js | 9 --------- lib/fs.js | 6 ------ lib/http.js | 4 +--- lib/https.js | 1 - lib/net.js | 1 - lib/punycode.js | 1 - lib/readline.js | 3 --- lib/repl.js | 2 +- lib/tty.js | 1 - 19 files changed, 5 insertions(+), 50 deletions(-) diff --git a/lib/_debugger.js b/lib/_debugger.js index f7b8252499..ff33af50d2 100644 --- a/lib/_debugger.js +++ b/lib/_debugger.js @@ -739,8 +739,7 @@ function SourceInfo(body) { // This class is the repl-enabled debugger interface which is invoked on // "node debug" function Interface(stdin, stdout, args) { - var self = this, - child; + var self = this; this.stdin = stdin; this.stdout = stdout; diff --git a/lib/_http_agent.js b/lib/_http_agent.js index 8309264685..7fa818fd6d 100644 --- a/lib/_http_agent.js +++ b/lib/_http_agent.js @@ -142,10 +142,6 @@ Agent.prototype.addRequest = function(req, options) { }; } - var host = options.host; - var port = options.port; - var localAddress = options.localAddress; - var name = this.getName(options); if (!this.sockets[name]) { this.sockets[name] = []; diff --git a/lib/_http_client.js b/lib/_http_client.js index 20e123c7f2..63f5ee9565 100644 --- a/lib/_http_client.js +++ b/lib/_http_client.js @@ -36,7 +36,6 @@ var IncomingMessage = require('_http_incoming').IncomingMessage; var OutgoingMessage = require('_http_outgoing').OutgoingMessage; var agent = require('_http_agent'); -var Agent = agent.Agent; var globalAgent = agent.globalAgent; @@ -308,7 +307,6 @@ function socketOnData(d) { // client function parserOnIncomingClient(res, shouldKeepAlive) { - var parser = this; var socket = this.socket; var req = socket._httpMessage; diff --git a/lib/_http_outgoing.js b/lib/_http_outgoing.js index 886cad4523..635e794906 100644 --- a/lib/_http_outgoing.js +++ b/lib/_http_outgoing.js @@ -28,7 +28,6 @@ var common = require('_http_common'); var CRLF = common.CRLF; var chunkExpression = common.chunkExpression; -var continueExpression = common.continueExpression; var debug = common.debug; @@ -194,7 +193,6 @@ OutgoingMessage.prototype._storeHeader = function(firstLine, headers) { }; var field, value; - var self = this; if (headers) { var keys = Object.keys(headers); @@ -457,7 +455,6 @@ OutgoingMessage.prototype.addTrailers = function(headers) { }; -var zero_chunk_buf = new Buffer('\r\n0\r\n'); var crlf_buf = new Buffer('\r\n'); diff --git a/lib/_stream_readable.js b/lib/_stream_readable.js index 7515ffbaa1..067be3cd4c 100644 --- a/lib/_stream_readable.js +++ b/lib/_stream_readable.js @@ -582,7 +582,6 @@ Readable.prototype.pipe = function(dest, pipeOpts) { function pipeOnDrain(src) { return function() { - var dest = this; var state = src._readableState; debug('pipeOnDrain', state.awaitDrain); if (state.awaitDrain) diff --git a/lib/_stream_transform.js b/lib/_stream_transform.js index d2bdcffe66..b1f9fcce11 100644 --- a/lib/_stream_transform.js +++ b/lib/_stream_transform.js @@ -112,7 +112,7 @@ function Transform(options) { Duplex.call(this, options); - var ts = this._transformState = new TransformState(options, this); + this._transformState = new TransformState(options, this); // when the writable side finishes, then flush out anything remaining. var stream = this; @@ -192,7 +192,6 @@ function done(stream, er) { // if there's nothing in the write buffer, then that means // that nothing more will ever be provided var ws = stream._writableState; - var rs = stream._readableState; var ts = stream._transformState; if (ws.length) diff --git a/lib/_stream_writable.js b/lib/_stream_writable.js index de96f83ed1..d091459620 100644 --- a/lib/_stream_writable.js +++ b/lib/_stream_writable.js @@ -27,7 +27,6 @@ module.exports = Writable; Writable.WritableState = WritableState; var util = require('util'); -var assert = require('assert'); var Stream = require('stream'); util.inherits(Writable, Stream); diff --git a/lib/_tls_wrap.js b/lib/_tls_wrap.js index ae6950b6a0..e475887e52 100644 --- a/lib/_tls_wrap.js +++ b/lib/_tls_wrap.js @@ -1,7 +1,6 @@ var assert = require('assert'); var constants = require('constants'); var crypto = require('crypto'); -var events = require('events'); var net = require('net'); var tls = require('tls'); var util = require('util'); @@ -132,8 +131,6 @@ function TLSSocket(socket, options) { writable: socket.writable }); - var self = this; - this._tlsOptions = options; this._secureEstablished = false; this._controlReleased = false; diff --git a/lib/buffer.js b/lib/buffer.js index 68f3f17f35..377ee61728 100644 --- a/lib/buffer.js +++ b/lib/buffer.js @@ -21,7 +21,6 @@ var buffer = process.binding('buffer'); var smalloc = process.binding('smalloc'); -var assert = require('assert'); var util = require('util'); var alloc = smalloc.alloc; var sliceOnto = smalloc.sliceOnto; diff --git a/lib/child_process.js b/lib/child_process.js index a0a2509631..f1550342ce 100644 --- a/lib/child_process.js +++ b/lib/child_process.js @@ -104,8 +104,6 @@ var handleConversion = { }, got: function(message, handle, emit) { - var self = this; - var server = new net.Server(); server.listen(handle, function() { emit(server); @@ -199,8 +197,6 @@ var handleConversion = { function SocketListSend(slave, key) { EventEmitter.call(this); - var self = this; - this.key = key; this.slave = slave; } @@ -585,7 +581,7 @@ exports.exec = function(command /*, options, callback */) { exports.execFile = function(file /* args, options, callback */) { - var args, optionArg, callback; + var args, callback; var options = { encoding: 'utf8', timeout: 0, diff --git a/lib/dgram.js b/lib/dgram.js index d623d89f78..8f19982525 100644 --- a/lib/dgram.js +++ b/lib/dgram.js @@ -32,18 +32,9 @@ var BIND_STATE_BOUND = 2; // lazily loaded var cluster = null; var dns = null; -var net = null; var errnoException = util._errnoException; -function isIP(address) { - if (!net) - net = require('net'); - - return net.isIP(address); -} - - function lookup(address, family, callback) { if (!dns) dns = require('dns'); diff --git a/lib/fs.js b/lib/fs.js index 3a3fe56c2b..29ef62f391 100644 --- a/lib/fs.js +++ b/lib/fs.js @@ -1158,12 +1158,6 @@ fs.unwatchFile = function(filename, listener) { } }; -// Realpath -// Not using realpath(2) because it's bad. -// See: http://insanecoding.blogspot.com/2007/11/pathmax-simply-isnt.html - -var normalize = pathModule.normalize; - // Regexp that finds the next partion of a (partial) path // result is [base_with_slash, base], e.g. ['somedir/', 'somedir'] if (isWindows) { diff --git a/lib/http.js b/lib/http.js index f3b6fe77cf..44c3c2ce50 100644 --- a/lib/http.js +++ b/lib/http.js @@ -28,7 +28,7 @@ var IncomingMessage = exports.IncomingMessage = incoming.IncomingMessage; var common = require('_http_common'); -var parsers = exports.parsers = common.parsers; +exports.parsers = common.parsers; var outgoing = require('_http_outgoing'); @@ -55,8 +55,6 @@ exports.get = function(options, cb) { return globalAgent.get(options, cb); }; -var httpSocketSetup = common.httpSocketSetup; - exports._connectionListener = server._connectionListener; var Server = exports.Server = server.Server; diff --git a/lib/https.js b/lib/https.js index a00b8bd6fe..0041986bd5 100644 --- a/lib/https.js +++ b/lib/https.js @@ -22,7 +22,6 @@ var tls = require('tls'); var http = require('http'); var util = require('util'); -var url = require('url'); var inherits = require('util').inherits; var debug = util.debuglog('https'); diff --git a/lib/net.js b/lib/net.js index bac7e47ece..2a80100bb1 100644 --- a/lib/net.js +++ b/lib/net.js @@ -747,7 +747,6 @@ Socket.prototype.__defineGetter__('bytesWritten', function() { function afterWrite(status, handle, req) { var self = handle.owner; - var state = self._writableState; if (self !== process.stderr && self !== process.stdout) debug('afterWrite', status); diff --git a/lib/punycode.js b/lib/punycode.js index 41803ba423..8a959552d8 100644 --- a/lib/punycode.js +++ b/lib/punycode.js @@ -228,7 +228,6 @@ k, digit, t, - length, /** Cached calculation results */ baseMinusT; diff --git a/lib/readline.js b/lib/readline.js index 60e725c8bd..c3d7095925 100644 --- a/lib/readline.js +++ b/lib/readline.js @@ -26,7 +26,6 @@ // * http://www.3waylabs.com/nw/WWW/products/wizcon/vt220.html var kHistorySize = 30; -var kBufSize = 10 * 1024; var util = require('util'); var inherits = require('util').inherits; @@ -213,8 +212,6 @@ Interface.prototype._addHistory = function() { Interface.prototype._refreshLine = function() { - var columns = this.columns; - // line length var line = this._prompt + this.line; var dispPos = this._getDisplayPos(line); diff --git a/lib/repl.js b/lib/repl.js index 7b501412f5..cf3322834a 100644 --- a/lib/repl.js +++ b/lib/repl.js @@ -447,7 +447,7 @@ REPLServer.prototype.complete = function(line, callback) { // list of completion lists, one for each inheritance "level" var completionGroups = []; - var completeOn, match, filter, i, j, group, c; + var completeOn, match, filter, i, group, c; // REPL commands (e.g. ".break"). var match = null; diff --git a/lib/tty.js b/lib/tty.js index 5c854edf09..74300fc1e4 100644 --- a/lib/tty.js +++ b/lib/tty.js @@ -19,7 +19,6 @@ // OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE // USE OR OTHER DEALINGS IN THE SOFTWARE. -var assert = require('assert'); var inherits = require('util').inherits; var net = require('net'); var TTY = process.binding('tty_wrap').TTY;