Browse Source

doc,test: enable recursive file watching in Windows

Recursive file watching is supported by libuv since 1.7.0. Refer
https://github.com/nodejs/node/blob/master/deps/uv/ChangeLog#L126. This
patch notes that in the docs and enables testing this feature. It also
adds proper TAP plugin parsable message for other platforms.

PR-URL: https://github.com/nodejs/node/pull/2649
Fixes: https://github.com/nodejs/node/issues/375
Reviewed-By: rvagg - Rod Vagg <rod@vagg.org>
Reviewed-By: silverwind - Roman Reiss <me@silverwind.io>
v4.x
Sakthipriyan Vairamani 10 years ago
committed by Rod Vagg
parent
commit
7038388558
  1. 6
      doc/api/fs.markdown
  2. 4
      test/sequential/test-fs-watch-recursive.js

6
doc/api/fs.markdown

@ -625,9 +625,9 @@ the event.
The `fs.watch` API is not 100% consistent across platforms, and is The `fs.watch` API is not 100% consistent across platforms, and is
unavailable in some situations. unavailable in some situations.
The recursive option is currently supported on OS X. Only FSEvents supports this The recursive option is currently supported on OS X and Windows. Only FSEvents
type of file watching so it is unlikely any additional platforms will be added supports this type of file watching so it is unlikely any additional platforms
soon. will be added soon.
#### Availability #### Availability

4
test/sequential/test-fs-watch-recursive.js

@ -4,7 +4,7 @@ var assert = require('assert');
var path = require('path'); var path = require('path');
var fs = require('fs'); var fs = require('fs');
if (process.platform === 'darwin') { if (process.platform === 'darwin' || common.isWindows) {
var watchSeenOne = 0; var watchSeenOne = 0;
var testDir = common.tmpDir; var testDir = common.tmpDir;
@ -46,4 +46,6 @@ if (process.platform === 'darwin') {
setTimeout(function() { setTimeout(function() {
fs.writeFileSync(filepathOne, 'world'); fs.writeFileSync(filepathOne, 'world');
}, 10); }, 10);
} else {
console.log('1..0 # Skipped: recursive option is darwin/windows specific');
} }

Loading…
Cancel
Save