Browse Source

build,tools: do not force codesign prefix

Allow passing the prefix in via the PKGDIR env var. This will allow us
to use this same script to codesign the binary tarball.

PR-URL: https://github.com/nodejs/node/pull/14179
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
v4.x-staging
Evan Lucas 8 years ago
committed by Myles Borins
parent
commit
70f2299c1e
No known key found for this signature in database GPG Key ID: 933B01F40B5CA946
  1. 3
      Makefile
  2. 2
      tools/osx-codesign.sh

3
Makefile

@ -515,7 +515,8 @@ $(PKG): release-only
--release-urlbase=$(RELEASE_URLBASE) \ --release-urlbase=$(RELEASE_URLBASE) \
$(CONFIG_FLAGS) $(BUILD_RELEASE_FLAGS) $(CONFIG_FLAGS) $(BUILD_RELEASE_FLAGS)
$(MAKE) install V=$(V) DESTDIR=$(PKGDIR) $(MAKE) install V=$(V) DESTDIR=$(PKGDIR)
SIGN="$(CODESIGN_CERT)" PKGDIR="$(PKGDIR)" bash tools/osx-codesign.sh SIGN="$(CODESIGN_CERT)" PKGDIR="$(PKGDIR)/usr/local" bash \
tools/osx-codesign.sh
cat tools/osx-pkg.pmdoc/index.xml.tmpl \ cat tools/osx-pkg.pmdoc/index.xml.tmpl \
| sed -E "s/\\{nodeversion\\}/$(FULLVERSION)/g" \ | sed -E "s/\\{nodeversion\\}/$(FULLVERSION)/g" \
| sed -E "s/\\{npmversion\\}/$(NPMVERSION)/g" \ | sed -E "s/\\{npmversion\\}/$(NPMVERSION)/g" \

2
tools/osx-codesign.sh

@ -8,4 +8,4 @@ if [ "X$SIGN" == "X" ]; then
exit 0 exit 0
fi fi
codesign -s "$SIGN" "$PKGDIR"/usr/local/bin/node codesign -s "$SIGN" "$PKGDIR"/bin/node

Loading…
Cancel
Save