From 7589a0007c2ad8ab9178bfe626f835e6b0b6f48c Mon Sep 17 00:00:00 2001 From: Fedor Indutny Date: Tue, 18 Feb 2014 02:47:33 +0400 Subject: [PATCH] crypto: make NewSessionDoneCb public Generic friend classes do not work well with old compiler versions (and MSVC). --- src/node_crypto.h | 3 +-- src/tls_wrap.h | 5 ++--- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/src/node_crypto.h b/src/node_crypto.h index 729d4fc7f4..6efd00deeb 100644 --- a/src/node_crypto.h +++ b/src/node_crypto.h @@ -247,6 +247,7 @@ class Connection : public SSLWrap, public AsyncWrap { } static void Initialize(Environment* env, v8::Handle target); + void NewSessionDoneCb(); #ifdef OPENSSL_NPN_NEGOTIATED v8::Persistent npnProtos_; @@ -295,7 +296,6 @@ class Connection : public SSLWrap, public AsyncWrap { void ClearError(); void SetShutdownFlags(); - void NewSessionDoneCb(); Connection(Environment* env, v8::Local wrap, @@ -324,7 +324,6 @@ class Connection : public SSLWrap, public AsyncWrap { friend class ClientHelloParser; friend class SecureContext; - friend class SSLWrap; }; class CipherBase : public BaseObject { diff --git a/src/tls_wrap.h b/src/tls_wrap.h index 646e70108f..13a53bfb30 100644 --- a/src/tls_wrap.h +++ b/src/tls_wrap.h @@ -67,6 +67,8 @@ class TLSCallbacks : public crypto::SSLWrap, uv_handle_type pending); int DoShutdown(ShutdownWrap* req_wrap, uv_shutdown_cb cb); + void NewSessionDoneCb(); + protected: static const int kClearOutChunkSize = 1024; @@ -102,7 +104,6 @@ class TLSCallbacks : public crypto::SSLWrap, void ClearOut(); void MakePending(); bool InvokeQueued(int status); - void NewSessionDoneCb(); inline void Cycle() { // Prevent recursion @@ -163,8 +164,6 @@ class TLSCallbacks : public crypto::SSLWrap, static size_t error_off_; static char error_buf_[1024]; - - friend class SSLWrap; }; } // namespace node