Browse Source

test: cleanup parallel/test-file-write-stream2.js

replace ==, !=, some instances of var, and assert.equal()

PR-URL: https://github.com/nodejs/node/pull/8770
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Teddy Katz <teddy.katz@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
v6
Jenna Vuong 8 years ago
committed by Ilkka Myller
parent
commit
782db084ad
  1. 14
      test/parallel/test-file-write-stream2.js

14
test/parallel/test-file-write-stream2.js

@ -9,9 +9,9 @@ var fs = require('fs');
var filepath = path.join(common.tmpDir, 'write.txt'); var filepath = path.join(common.tmpDir, 'write.txt');
var file; var file;
var EXPECTED = '012345678910'; const EXPECTED = '012345678910';
var cb_expected = 'write open drain write drain close error '; const cb_expected = 'write open drain write drain close error ';
var cb_occurred = ''; var cb_occurred = '';
var countDrains = 0; var countDrains = 0;
@ -48,7 +48,7 @@ file = fs.createWriteStream(filepath, {
file.on('open', function(fd) { file.on('open', function(fd) {
console.error('open'); console.error('open');
cb_occurred += 'open '; cb_occurred += 'open ';
assert.equal(typeof fd, 'number'); assert.strictEqual(typeof fd, 'number');
}); });
file.on('drain', function() { file.on('drain', function() {
@ -57,12 +57,12 @@ file.on('drain', function() {
++countDrains; ++countDrains;
if (countDrains === 1) { if (countDrains === 1) {
console.error('drain=1, write again'); console.error('drain=1, write again');
assert.equal(fs.readFileSync(filepath, 'utf8'), EXPECTED); assert.strictEqual(fs.readFileSync(filepath, 'utf8'), EXPECTED);
console.error('ondrain write ret=%j', file.write(EXPECTED)); console.error('ondrain write ret=%j', file.write(EXPECTED));
cb_occurred += 'write '; cb_occurred += 'write ';
} else if (countDrains == 2) { } else if (countDrains === 2) {
console.error('second drain, end'); console.error('second drain, end');
assert.equal(fs.readFileSync(filepath, 'utf8'), EXPECTED + EXPECTED); assert.strictEqual(fs.readFileSync(filepath, 'utf8'), EXPECTED + EXPECTED);
file.end(); file.end();
} }
}); });
@ -85,6 +85,6 @@ for (var i = 0; i < 11; i++) {
console.error('%d %j', i, ret); console.error('%d %j', i, ret);
// return false when i hits 10 // return false when i hits 10
assert.strictEqual(ret, i != 10); assert.strictEqual(ret, i !== 10);
} }
cb_occurred += 'write '; cb_occurred += 'write ';

Loading…
Cancel
Save