Browse Source

build: fix g++ 4.8 build, disable -Werror

Turn off -Werror when building V8, it hits -Werror=unused-local-typedefs
with g++ 4.8.  The warning itself is harmless so don't abort the build.

This was originally implemented in commit d2ab314e back in 2011 but the
build process has gone through a few iterations since then, that change
no longer works.
v0.10.27-release
Ben Noordhuis 11 years ago
committed by Timothy J Fontaine
parent
commit
7989f42f86
  1. 1
      common.gypi
  2. 3
      node.gyp

1
common.gypi

@ -1,5 +1,6 @@
{ {
'variables': { 'variables': {
'werror': '', # Turn off -Werror in V8 build.
'visibility%': 'hidden', # V8's visibility setting 'visibility%': 'hidden', # V8's visibility setting
'target_arch%': 'ia32', # set v8's target architecture 'target_arch%': 'ia32', # set v8's target architecture
'host_arch%': 'ia32', # set v8's host architecture 'host_arch%': 'ia32', # set v8's host architecture

3
node.gyp

@ -1,9 +1,6 @@
{ {
'variables': { 'variables': {
'v8_use_snapshot%': 'true', 'v8_use_snapshot%': 'true',
# Turn off -Werror in V8
# See http://codereview.chromium.org/8159015
'werror': '',
'node_use_dtrace%': 'false', 'node_use_dtrace%': 'false',
'node_use_etw%': 'false', 'node_use_etw%': 'false',
'node_use_perfctr%': 'false', 'node_use_perfctr%': 'false',

Loading…
Cancel
Save